regression: Hide prune section based on permission #32531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this PR is ready to merge! 🎉 |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-6.9.0 #32531 +/- ##
==============================================
Coverage 56.01% 56.01%
==============================================
Files 2431 2431
Lines 53556 53555 -1
Branches 11029 11028 -1
==============================================
Hits 29998 29998
+ Misses 20929 20928 -1
Partials 2629 2629
Flags with carried forward coverage won't be shown. Click here to find out more. |
ggazzo
approved these changes
May 31, 2024
ggazzo
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
gabriellsh
added a commit
that referenced
this pull request
Jun 3, 2024
…retention * 'develop' of github.com:RocketChat/Rocket.Chat: Release 6.9.0 Release 6.9.0-rc.2 fix: User status when setting "Use REST instead of websocket for Meteor calls" is disabled (#32500) fix: User status when setting "Use REST instead of websocket for Meteor calls" is disabled (#32500) regression: Hide prune section based on permission (#32531) fix: Users in role table not rendering the empty state properly (#32412) refactor: EmailInbox out of DB Watcher (#32501) ci: increase issue allowed stale time (#32523) regression: Remove impossible sorting from users table "registration status" column (#32506) feat: Add contentDisposition option to file storages (#31974) i18n: Rocket.Chat language update from LingoHub 🤖 on 2024-05-28Z (#32508) Release 6.9.0-rc.1 fix: Re-login same browser tab issues (#32479) regression: Replace read receipt single icon (#32486) regression: Incorrect retention policy banner's display rule for teams (#32483) chore: Publish npm packages again (#32463) ci: publish missing Omnichannel services to DockerHub (#32462) Release 6.9.0-rc.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Showing the retention policy section on edit room panel for users without permission are throwing error not allowing users editing room at all
Issue(s)
Steps to test or reproduce
Further comments
CORE-478