feat: E2EE room setup header #32446
Merged
feat: E2EE room setup header #32446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: yash-rajpal <[email protected]>
…nd restoring commented test
hugocostadev
previously approved these changes
May 20, 2024
MarcosSpessatto
requested changes
Jun 11, 2024
Co-authored-by: Marcos Spessatto Defendi <[email protected]>
Co-authored-by: Marcos Spessatto Defendi <[email protected]>
MarcosSpessatto
approved these changes
Jun 16, 2024
hugocostadev
approved these changes
Jun 17, 2024
milton-rucks
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
gabriellsh
added a commit
that referenced
this pull request
Jun 18, 2024
…retention * 'develop' of github.com:RocketChat/Rocket.Chat: fix: Not possible to edit room without proper permission with retention policy enabled (#32547) feat: Apps-Engine Deno Runtime update (#31821) feat: E2EE room setup header (#32446) fix: E2EE thread main message reactivity (#32381) chore: Add telemetry to CI so we can get a better understanding of resource usage (#32113) fix: Long katex strings breaking overflow in x axis (#32609) fix: Force highlighted code language registration (#32507) fix: sidebar last message E2EE (#32431) chore: remove message column on moderation console (#32432) fix: Accepted Media Types settings validation (#32478)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new Header for the E2EE room setup flow, idea is that we shouldn't show all the room actions on the setup window and only a few items makes sense to be kept on this Header.
This PR introduces a new E2EERoomHeaderToolbox which is a toolbox for this specific use-case which contains only 3 room actions, e2e, room-info and members tab.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments
E2EE-27