fix: Not possible to edit room without proper permission with retention policy enabled #32547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 4c79caa The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32547 +/- ##
===========================================
+ Coverage 56.39% 56.41% +0.01%
===========================================
Files 2479 2479
Lines 54580 54581 +1
Branches 11268 11268
===========================================
+ Hits 30780 30790 +10
+ Misses 21125 21115 -10
- Partials 2675 2676 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
dougfabris
changed the title
edit-room-retention-policy permission
MarcosSpessatto
previously approved these changes
Jun 7, 2024
gabriellsh
approved these changes
Jun 18, 2024
scuciatto
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
gabriellsh
added a commit
that referenced
this pull request
Jun 18, 2024
…retention * 'develop' of github.com:RocketChat/Rocket.Chat: fix: Not possible to edit room without proper permission with retention policy enabled (#32547) feat: Apps-Engine Deno Runtime update (#31821) feat: E2EE room setup header (#32446) fix: E2EE thread main message reactivity (#32381) chore: Add telemetry to CI so we can get a better understanding of resource usage (#32113) fix: Long katex strings breaking overflow in x axis (#32609) fix: Force highlighted code language registration (#32507) fix: sidebar last message E2EE (#32431) chore: remove message column on moderation console (#32432) fix: Accepted Media Types settings validation (#32478)
|
/backport 6.9.2 |
|
Sorry, I couldn't do that backport because of conflicts. Could you please solve them? you can do so by running the following commands: after that just run |
dougfabris
added a commit
that referenced
this pull request
Jun 18, 2024
…on policy enabled (#32547)
|
/backport 6.9.2 |
|
Pull request #32622 added to Project: "Patch 6.9.2" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Fixes the issue not allowing users without
edit-room-retention-policypermission try to edit the room with the retention policy enabledIssue(s)
Steps to test or reproduce
Further comments
CORE-486
SUP-602