Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: removed roomNameExists method #32484

Merged
merged 3 commits into from
Aug 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion apps/meteor/app/api/server/v1/rooms.ts
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,9 @@ API.v1.addRoute(
async get() {
const { roomName } = this.queryParams;

return API.v1.success({ exists: await Meteor.callAsync('roomNameExists', roomName) });
const room = await Rooms.findOneByName(roomName, { projection: { _id: 1 } });

return API.v1.success({ exists: !!room });
},
},
);
Expand Down
1 change: 0 additions & 1 deletion apps/meteor/server/methods/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ import './removeUserFromRoom';
import './reportMessage';
import './requestDataDownload';
import './resetAvatar';
import './roomNameExists';
import './saveUserPreferences';
import './saveUserProfile';
import './sendConfirmationEmail';
Expand Down
34 changes: 0 additions & 34 deletions apps/meteor/server/methods/roomNameExists.ts

This file was deleted.

17 changes: 16 additions & 1 deletion apps/meteor/tests/end-to-end/api/rooms.ts
Original file line number Diff line number Diff line change
Expand Up @@ -831,7 +831,22 @@ describe('[Rooms]', () => {
.end(done);
});

it('should return an error when send an invalid room', (done) => {
it('should return false if this room name does not exist', (done) => {
void request
.get(api('rooms.nameExists'))
.set(credentials)
.query({
roomName: 'foo',
})
.expect(200)
.expect((res) => {
expect(res.body).to.have.property('success', true);
expect(res.body).to.have.property('exists', false);
})
.end(done);
});

it('should return an error when the require parameter (roomName) is not provided', (done) => {
void request
.get(api('rooms.nameExists'))
.set(credentials)
Expand Down
Loading