feat: verify federation configuration before processing any events #32535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 72e606d The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #32535 +/- ##
===========================================
- Coverage 59.44% 59.43% -0.01%
===========================================
Files 2544 2546 +2
Lines 63239 63255 +16
Branches 14235 14235
===========================================
+ Hits 37590 37594 +4
- Misses 22930 22941 +11
- Partials 2719 2720 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
debdutdeb
changed the title
MarcosSpessatto
requested changes
Jun 11, 2024
debdutdeb
force-pushed
the
federation-verify-config
branch
from
b64dc2c
to
77ded52
Compare
debdutdeb
commented
Jul 31, 2024
apps/meteor/app/lib/server/methods/checkFederationConfiguration.ts
Outdated
Show resolved
Hide resolved
MarcosSpessatto
requested changes
Aug 14, 2024
apps/meteor/server/services/federation/domain/IFederationBridge.ts
Outdated
Show resolved
Hide resolved
apps/meteor/server/services/federation/infrastructure/matrix/Bridge.ts
Outdated
Show resolved
Hide resolved
apps/meteor/server/services/federation/infrastructure/matrix/Bridge.ts
Outdated
Show resolved
Hide resolved
apps/meteor/server/services/federation/infrastructure/matrix/Bridge.ts
Outdated
Show resolved
Hide resolved
…s invalid or it is disabled (#32838) * i think i covered all * .. * ... * remove lines * fix and move methods * ee hooks * ? * typescript hiya thanks * wrong params * typescript and linter * lint * mock right you stupid me * ??? * hehe * prettier? * don't run if fed not enabled * fix unit tests * rename function * rememver to remove callback * federation tests * type federation utils functions' returns * type room service methods * rename function * review * change how blocks * stupidity * review * no breaking changes * review * review * oh conflict resolution * types * tests changed * new tests * consistent naming * review * ops
debdutdeb
force-pushed
the
federation-verify-config
branch
from
1e58bc4
to
1fdc2c9
Compare
MarcosSpessatto
approved these changes
Aug 21, 2024
debdutdeb
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://rocketchat.atlassian.net/browse/CORE-479
https://rocketchat.atlassian.net/browse/CORE-518
Proposed changes (including videos or screenshots)
We need to verify homeserver <> appservice connection, which is achieved by https://spec.matrix.org/v1.10/application-service-api/#pinging
Also if rocketchat itself is ready for federation or not, using https://federationtester.matrix.org/
Issue(s)
Steps to test or reproduce
Further comments