Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve UX from "Action Buttons" in RoomInfo #32632

Merged
merged 21 commits into from
Jul 22, 2024

Conversation

tiagoevanp
Copy link
Contributor

@tiagoevanp tiagoevanp commented Jun 19, 2024

Proposed changes (including videos or screenshots)

Improve the UX from "Action Buttons" inside the contextualbar in RoomInfo component

Before:
image

After:
image

Issue(s)

Steps to test or reproduce

Further comments

CORE-464

Copy link
Contributor

dionisio-bot bot commented Jun 19, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jun 19, 2024

🦋 Changeset detected

Latest commit: e08a7a2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tiagoevanp tiagoevanp changed the title chore: Change "Action Buttons design chore: Change "Action Buttons" design Jun 19, 2024
@tiagoevanp tiagoevanp changed the title chore: Change "Action Buttons" design chore: Improve UX from "Action Buttons" in RoomInfo Jun 19, 2024
Copy link

codecov bot commented Jun 19, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 8 lines in your changes missing coverage. Please review.

Project coverage is 55.63%. Comparing base (703af95) to head (e08a7a2).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32632      +/-   ##
===========================================
+ Coverage    55.56%   55.63%   +0.07%     
===========================================
  Files         2635     2637       +2     
  Lines        57292    57308      +16     
  Branches     11865    11868       +3     
===========================================
+ Hits         31834    31884      +50     
+ Misses       22768    22734      -34     
  Partials      2690     2690              
Flag Coverage Δ
e2e 54.38% <71.42%> (+0.09%) ⬆️
unit 72.34% <ø> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@tiagoevanp tiagoevanp marked this pull request as ready for review June 19, 2024 19:27
@tiagoevanp tiagoevanp requested a review from a team as a code owner June 19, 2024 19:27
@tiagoevanp tiagoevanp added this to the 6.10 milestone Jun 19, 2024
@dougfabris
Copy link
Member

if you're going to improve the UX it will change something to the end user, so it shouldn't be a chore

@MarcosSpessatto
Copy link
Member

if you're going to improve the UX it will change something to the end user, so it shouldn't be a chore

Maybe a fix would fit better in this case, also adding a changeset.

@tiagoevanp tiagoevanp changed the title chore: Improve UX from "Action Buttons" in RoomInfo fix: Improve UX from "Action Buttons" in RoomInfo Jun 20, 2024
@dougfabris
Copy link
Member

@tiagoevanp if you're improving, it's not a fix 😞

@scuciatto scuciatto removed this from the 6.10 milestone Jun 21, 2024
@tiagoevanp tiagoevanp modified the milestone: 6.10 Jun 21, 2024
@tiagoevanp tiagoevanp changed the title fix: Improve UX from "Action Buttons" in RoomInfo feat: Improve UX from "Action Buttons" in RoomInfo Jun 24, 2024
dougfabris
dougfabris previously approved these changes Jun 27, 2024
Copy link
Member

@dougfabris dougfabris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@scuciatto scuciatto added this to the 6.11 milestone Jul 3, 2024
@scuciatto scuciatto added the stat: QA assured Means it has been tested and approved by a company insider label Jul 17, 2024
dougfabris
dougfabris previously approved these changes Jul 17, 2024
@dougfabris dougfabris added the stat: ready to merge PR tested and approved waiting for merge label Jul 19, 2024
@kodiakhq kodiakhq bot merged commit 5bfde8d into develop Jul 22, 2024
49 checks passed
@kodiakhq kodiakhq bot deleted the improvement/room-info-ux branch July 22, 2024 17:37
gabriellsh added a commit that referenced this pull request Jul 22, 2024
…threadEdit

* 'develop' of github.com:RocketChat/Rocket.Chat:
  feat: Improve UX from "Action Buttons" in `RoomInfo` (#32632)
  fix: Attachments not downloading on non-encrypted rooms (#32837)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants