-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Improve UX from "Action Buttons" in RoomInfo
#32632
Conversation
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: e08a7a2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
RoomInfo
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #32632 +/- ##
===========================================
+ Coverage 55.56% 55.63% +0.07%
===========================================
Files 2635 2637 +2
Lines 57292 57308 +16
Branches 11865 11868 +3
===========================================
+ Hits 31834 31884 +50
+ Misses 22768 22734 -34
Partials 2690 2690
Flags with carried forward coverage won't be shown. Click here to find out more. |
if you're going to improve the UX it will change something to the end user, so it shouldn't be a |
Maybe a fix would fit better in this case, also adding a changeset. |
RoomInfo
RoomInfo
apps/meteor/client/views/room/contextualBar/Info/RoomInfo/Actions.tsx
Outdated
Show resolved
Hide resolved
apps/meteor/client/views/room/contextualBar/Info/RoomInfo/RoomActionsMenu.tsx
Outdated
Show resolved
Hide resolved
apps/meteor/client/views/room/contextualBar/Info/hooks/useRoomActions.ts
Show resolved
Hide resolved
apps/meteor/client/views/room/contextualBar/Info/hooks/useRoomActions.ts
Outdated
Show resolved
Hide resolved
@tiagoevanp if you're improving, it's not a fix 😞 |
apps/meteor/client/views/room/contextualBar/Info/hooks/useRoomActions.ts
Outdated
Show resolved
Hide resolved
RoomInfo
RoomInfo
apps/meteor/client/views/room/contextualBar/Info/hooks/useSplitRoomActions.ts
Outdated
Show resolved
Hide resolved
apps/meteor/client/views/room/contextualBar/Info/hooks/useSplitRoomActions.ts
Outdated
Show resolved
Hide resolved
apps/meteor/tests/e2e/page-objects/fragments/home-flextab-room.ts
Outdated
Show resolved
Hide resolved
apps/meteor/tests/e2e/page-objects/fragments/home-flextab-room.ts
Outdated
Show resolved
Hide resolved
…tRoomActions.ts Co-authored-by: Douglas Fabris <[email protected]>
…tRoomActions.ts Co-authored-by: Douglas Fabris <[email protected]>
Co-authored-by: Douglas Fabris <[email protected]>
…ovement/room-info-ux
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…ovement/room-info-ux
Proposed changes (including videos or screenshots)
Improve the UX from "Action Buttons" inside the contextualbar in RoomInfo component
Before:
After:
Issue(s)
Steps to test or reproduce
Further comments
CORE-464