-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Attachments not downloading on non-encrypted rooms #32837
Conversation
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: bf5b8f0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #32837 +/- ##
===========================================
- Coverage 55.60% 55.55% -0.06%
===========================================
Files 2635 2635
Lines 57289 57292 +3
Branches 11864 11865 +1
===========================================
- Hits 31858 31826 -32
- Misses 22742 22769 +27
- Partials 2689 2697 +8
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Proposed changes (including videos or screenshots)
The downloading event was trying to decrypt not encrypted files, causing the issue.
Issue(s)
SUP-626
Steps to test or reproduce
Further comments