Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Attachments not downloading on non-encrypted rooms #32837

Merged
merged 4 commits into from
Jul 22, 2024

Conversation

gabriellsh
Copy link
Member

@gabriellsh gabriellsh commented Jul 18, 2024

Proposed changes (including videos or screenshots)

The downloading event was trying to decrypt not encrypted files, causing the issue.

Issue(s)

SUP-626

Steps to test or reproduce

Further comments

@gabriellsh gabriellsh requested a review from a team as a code owner July 18, 2024 21:15
Copy link
Contributor

dionisio-bot bot commented Jul 18, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jul 18, 2024

🦋 Changeset detected

Latest commit: bf5b8f0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Jul 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 55.55%. Comparing base (88e5219) to head (bf5b8f0).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32837      +/-   ##
===========================================
- Coverage    55.60%   55.55%   -0.06%     
===========================================
  Files         2635     2635              
  Lines        57289    57292       +3     
  Branches     11864    11865       +1     
===========================================
- Hits         31858    31826      -32     
- Misses       22742    22769      +27     
- Partials      2689     2697       +8     
Flag Coverage Δ
e2e 54.26% <0.00%> (-0.07%) ⬇️
unit 72.23% <ø> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@yash-rajpal yash-rajpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jeanfbrito
Copy link
Contributor

Tested and is working as intended.
chuck-norris-thumbs-up

@jessicaschelly jessicaschelly added stat: QA assured Means it has been tested and approved by a company insider and removed stat: QA assured Means it has been tested and approved by a company insider labels Jul 19, 2024
@scuciatto scuciatto added the stat: ready to merge PR tested and approved waiting for merge label Jul 20, 2024
@MarcosSpessatto MarcosSpessatto added this to the 6.11 milestone Jul 22, 2024
@kodiakhq kodiakhq bot merged commit 703af95 into develop Jul 22, 2024
49 checks passed
@kodiakhq kodiakhq bot deleted the fix/e2eeFileDownload branch July 22, 2024 15:11
gabriellsh added a commit that referenced this pull request Jul 22, 2024
…threadEdit

* 'develop' of github.com:RocketChat/Rocket.Chat:
  feat: Improve UX from "Action Buttons" in `RoomInfo` (#32632)
  fix: Attachments not downloading on non-encrypted rooms (#32837)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants