Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: fix retention flaky test #32649

Merged
merged 1 commit into from
Jun 21, 2024
Merged

regression: fix retention flaky test #32649

merged 1 commit into from
Jun 21, 2024

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Jun 21, 2024

introduced here: #32485

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Copy link

changeset-bot bot commented Jun 21, 2024

⚠️ No Changeset found

Latest commit: d0bb86b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

dionisio-bot bot commented Jun 21, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@ggazzo ggazzo changed the title tests: fix retention flaky test test: fix retention flaky test Jun 21, 2024
Copy link

codecov bot commented Jun 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.59%. Comparing base (e47ae76) to head (d0bb86b).
Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32649      +/-   ##
===========================================
- Coverage    56.62%   56.59%   -0.03%     
===========================================
  Files         2486     2489       +3     
  Lines        54921    54956      +35     
  Branches     11364    11371       +7     
===========================================
+ Hits         31097    31104       +7     
- Misses       21151    21166      +15     
- Partials      2673     2686      +13     
Flag Coverage Δ
e2e 56.18% <50.00%> (-0.02%) ⬇️
unit 72.10% <100.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo marked this pull request as ready for review June 21, 2024 05:58
@ggazzo ggazzo requested a review from a team as a code owner June 21, 2024 05:58
@ggazzo ggazzo changed the title test: fix retention flaky test regression: fix retention flaky test Jun 21, 2024
Copy link
Member

@gabriellsh gabriellsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let that one pass by, thanks a lot for the fix!

@ggazzo ggazzo merged commit 6274c43 into develop Jun 21, 2024
50 of 52 checks passed
@ggazzo ggazzo deleted the tests/flaky-retention branch June 21, 2024 12:48
@ggazzo ggazzo added this to the 6.10 milestone Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants