-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
regression: fix retention flaky test #32649
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32649 +/- ##
===========================================
- Coverage 56.62% 56.59% -0.03%
===========================================
Files 2486 2489 +3
Lines 54921 54956 +35
Branches 11364 11371 +7
===========================================
+ Hits 31097 31104 +7
- Misses 21151 21166 +15
- Partials 2673 2686 +13
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let that one pass by, thanks a lot for the fix!
introduced here: #32485
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments