fix: Override retention policy missing ignore threads option #32485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: db0434c The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32485 +/- ##
===========================================
- Coverage 56.56% 56.49% -0.08%
===========================================
Files 2484 2484
Lines 54755 54728 -27
Branches 11308 11300 -8
===========================================
- Hits 30971 30917 -54
- Misses 21107 21139 +32
+ Partials 2677 2672 -5
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
/bark |
|
woof |
MarcosSpessatto
requested changes
Jun 10, 2024
dougfabris
force-pushed
the
fix/retention-threads
branch
from
7158079
to
05ee098
Compare
dougfabris
force-pushed
the
fix/retention-threads
branch
from
05ee098
to
10ce987
Compare
dougfabris
force-pushed
the
fix/retention-threads
branch
from
1dc145d
to
db0434c
Compare
MarcosSpessatto
approved these changes
Jun 20, 2024
jessicaschelly
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Adds the missing
ignoreThreadsparam fixing the issue not allowing ignoring threads when overriding retention policyIssue(s)
Closes #19731
Closes #22384
Closes #18738
Steps to test or reproduce
Further comments
CORE-487