feat: Video Conference persistent chat #32793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 09aec45 The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32793 +/- ##
===========================================
- Coverage 55.47% 55.46% -0.02%
===========================================
Files 2637 2637
Lines 57319 57290 -29
Branches 11869 11859 -10
===========================================
- Hits 31798 31774 -24
+ Misses 22829 22827 -2
+ Partials 2692 2689 -3
Flags with carried forward coverage won't be shown. Click here to find out more. |
…en as valid while the update isn't available
…show any kind of VideoConference and not just IGroupVideoConference
…ge and instead show a button to access the discussion on the videoconf block directly
… name instead of the expected id
KevLehman
reviewed
Jul 22, 2024
d-gubert
previously approved these changes
Jul 22, 2024
MarcosSpessatto
requested changes
Jul 23, 2024
tassoevan
previously approved these changes
Jul 23, 2024
pierre-lehnen-rc
dismissed stale reviews from tassoevan and d-gubert
via
c436fc2
tassoevan
approved these changes
Jul 23, 2024
d-gubert
approved these changes
Jul 23, 2024
jessicaschelly
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
MarcosSpessatto
approved these changes
Jul 23, 2024
KevLehman
approved these changes
Jul 23, 2024
Merged
debdutdeb
pushed a commit
that referenced
this pull request
Jul 31, 2024
Co-authored-by: Guilherme Gazzo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
This new feature allows video conference provider apps to use a rocket.chat discussion to store the messages sent by their users during a conference call. The feature is enabled through a setting on rocket.chat workspace configuration, but it will only take effect if the video conf provider app registers itself as compatible with it.
When enabled, Rocket.Chat will automatically create a new discussion every time a conference is started and the id of this discussion will be made available to the app. Any user who joins the conference will automatically be subscribed to that discussion. The provider app is then responsible for actually sending any messages exchanged during the conference to the specified discussion.
Issue(s)
PPC-1
ADR 092
Steps to test or reproduce
Further comments
Discussions created for conference calls will not be listed on the room's list of discussions. They can be accessed through the list of conference calls instead. A button to access the discussion is also available on the message sent when a conference is started.
Includes PR #32817