Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ui-contexts): useGoToRoom #32817

Merged
merged 9 commits into from
Jul 19, 2024
Merged

chore(ui-contexts): useGoToRoom #32817

merged 9 commits into from
Jul 19, 2024

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Jul 17, 2024

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Copy link

changeset-bot bot commented Jul 17, 2024

⚠️ No Changeset found

Latest commit: 5709c9d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

dionisio-bot bot commented Jul 17, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

codecov bot commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 55.60%. Comparing base (d0490d3) to head (5709c9d).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32817      +/-   ##
===========================================
+ Coverage    55.57%   55.60%   +0.03%     
===========================================
  Files         2634     2634              
  Lines        57279    57252      -27     
  Branches     11860    11853       -7     
===========================================
+ Hits         31832    31836       +4     
+ Misses       22791    22760      -31     
  Partials      2656     2656              
Flag Coverage Δ
unit 72.33% <0.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@pierre-lehnen-rc pierre-lehnen-rc added the stat: QA assured Means it has been tested and approved by a company insider label Jul 17, 2024
@pierre-lehnen-rc pierre-lehnen-rc marked this pull request as ready for review July 17, 2024 22:28
@pierre-lehnen-rc pierre-lehnen-rc requested review from a team as code owners July 17, 2024 22:28
@ggazzo ggazzo added this to the 6.11 milestone Jul 18, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jul 18, 2024
Copy link
Member

@dougfabris dougfabris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ggazzo ggazzo merged commit e6ce4ee into develop Jul 19, 2024
39 of 40 checks passed
@ggazzo ggazzo deleted the chore/useGoToRoom branch July 19, 2024 21:28
debdutdeb pushed a commit that referenced this pull request Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants