Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Client crashing on firefox private window #32807

Merged
merged 8 commits into from
Jul 19, 2024
Merged

Conversation

yash-rajpal
Copy link
Member

@yash-rajpal yash-rajpal commented Jul 17, 2024

Proposed changes (including videos or screenshots)

The web client was crashing on firefox's private window, due to unavailability of service workers on private window.

This PR handles this case, the limitation being that users cannot view or download the encrypted attachments on firefox private window.

Issue(s)

Closes #32758
Closes #32826

Steps to test or reproduce

Further comments

https://rocketchat.atlassian.net/browse/CORE-559

Copy link
Contributor

dionisio-bot bot commented Jul 17, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jul 17, 2024

🦋 Changeset detected

Latest commit: c3ee33f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 27.27273% with 8 lines in your changes missing coverage. Please review.

Project coverage is 55.52%. Comparing base (d3a6299) to head (c3ee33f).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32807      +/-   ##
===========================================
- Coverage    55.57%   55.52%   -0.05%     
===========================================
  Files         2634     2634              
  Lines        57248    57252       +4     
  Branches     11853    11857       +4     
===========================================
- Hits         31816    31791      -25     
- Misses       22748    22766      +18     
- Partials      2684     2695      +11     
Flag Coverage Δ
e2e 54.24% <27.27%> (-0.06%) ⬇️
unit 72.07% <ø> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@yash-rajpal yash-rajpal marked this pull request as ready for review July 17, 2024 15:56
@yash-rajpal yash-rajpal requested a review from a team as a code owner July 17, 2024 15:56
@yash-rajpal yash-rajpal added this to the 6.11 milestone Jul 17, 2024
Copy link
Contributor

@MartinSchoeler MartinSchoeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned via chat, the channel files tab is crashing the browser too, we need to check if there any other places that tries to access the problematic property

@jessicaschelly jessicaschelly added the stat: QA assured Means it has been tested and approved by a company insider label Jul 19, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jul 19, 2024
@scuciatto scuciatto added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Jul 19, 2024
@kodiakhq kodiakhq bot merged commit ebc858f into develop Jul 19, 2024
51 checks passed
@kodiakhq kodiakhq bot deleted the fix/e2ee-file-disabled branch July 19, 2024 18:32
@sampaiodiego
Copy link
Member

/patch

Copy link
Contributor

dionisio-bot bot commented Jul 29, 2024

    Sorry, I couldn't do that backport because of conflicts. Could you please solve them?
    
    you can do so by running the following commands:
git fetch
git checkout backport-6.10.2-32807
git cherry-pick ebc858fcbe6d2f340835dc76e3e765665bc2e825
// solve the conflict
git push

after that just run /patch again

@d-gubert
Copy link
Member

/patch

Copy link
Contributor

dionisio-bot bot commented Jul 31, 2024

Pull request #32946 added to Project: "Patch 6.10.2"

@sampaiodiego
Copy link
Member

/patch

Copy link
Contributor

dionisio-bot bot commented Jul 31, 2024

    Sorry, I couldn't do that backport because of conflicts. Could you please solve them?
    
    you can do so by running the following commands:
git fetch
git checkout backport-6.10.2-32807
git cherry-pick ebc858fcbe6d2f340835dc76e3e765665bc2e825
// solve the conflict
git push

after that just run /patch again

@sampaiodiego
Copy link
Member

/patch

Copy link
Contributor

dionisio-bot bot commented Jul 31, 2024

Pull request #32950 added to Project: "Patch 6.10.2"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
7 participants