Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Client crashing on firefox private window #32946

Closed
wants to merge 0 commits into from

Conversation

dionisio-bot[bot]
Copy link
Contributor

@dionisio-bot dionisio-bot bot commented Jul 31, 2024

Backport of #32807

@dionisio-bot dionisio-bot bot requested a review from a team as a code owner July 31, 2024 00:13
@dionisio-bot dionisio-bot bot requested a review from yash-rajpal July 31, 2024 00:13
Copy link

changeset-bot bot commented Jul 31, 2024

⚠️ No Changeset found

Latest commit: e1b4c28

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor Author

dionisio-bot bot commented Jul 31, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

codecov bot commented Jul 31, 2024

Codecov Report

Attention: Patch coverage is 27.27273% with 8 lines in your changes missing coverage. Please review.

Project coverage is 56.64%. Comparing base (636382f) to head (ee7987e).
Report is 1 commits behind head on release-6.10.2.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           release-6.10.2   #32946      +/-   ##
==================================================
- Coverage           56.69%   56.64%   -0.05%     
==================================================
  Files                2505     2503       -2     
  Lines               55609    55587      -22     
  Branches            11486    11488       +2     
==================================================
- Hits                31526    31486      -40     
+ Misses              21425    21409      -16     
- Partials             2658     2692      +34     
Flag Coverage Δ
e2e 56.45% <27.27%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@sampaiodiego
Copy link
Member

/rebase

Copy link
Contributor Author

dionisio-bot bot commented Jul 31, 2024

    Sorry, I couldn't rebase this pull request because of conflicts. Could you please solve them?
    
    you can do so by running the following commands:
git fetch
git checkout backport-6.10.2-32807
git cherry-pick ebc858fcbe6d2f340835dc76e3e765665bc2e825
// solve the conflict
git push

@dionisio-bot dionisio-bot bot closed this Jul 31, 2024
@sampaiodiego sampaiodiego deleted the backport-6.10.2-32807 branch July 31, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants