Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: markdown text component #32914

Closed
wants to merge 2 commits into from
Closed

Conversation

csuadev
Copy link
Contributor

@csuadev csuadev commented Jul 26, 2024

This PR adds tests for the markdown text component to ensure the behavior from this PR to solve small inconsistencies with the message composer: #32574

Proposed changes (including videos or screenshots)

Issue(s)

https://rocketchat.atlassian.net/browse/SUP-537

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Jul 26, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jul 26, 2024

⚠️ No Changeset found

Latest commit: 883a917

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.51%. Comparing base (6cb79a0) to head (883a917).
Report is 27 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32914      +/-   ##
===========================================
- Coverage    59.44%   55.51%   -3.93%     
===========================================
  Files         2544     2636      +92     
  Lines        63239    57400    -5839     
  Branches     14235    11895    -2340     
===========================================
- Hits         37590    31864    -5726     
+ Misses       22930    22816     -114     
- Partials      2719     2720       +1     

@csuadev csuadev closed this Aug 26, 2024
@csuadev csuadev deleted the test/markdown-text-component branch August 26, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant