Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Inconsistent Markdown Formatting in Custom Status Field #32574

Merged
merged 31 commits into from
Aug 21, 2024

Conversation

Kishn0109
Copy link
Contributor

@Kishn0109 Kishn0109 commented Jun 8, 2024

https://rocketchat.atlassian.net/browse/SUP-537

Proposed changes (including videos or screenshots)

Screen.Recording.-.Jun.8.2024.mp4

Issue(s)

Closes #32544
Closes #32081

Steps to test or reproduce

  1. Navigate to the Profile section.
  2. Enter a Custom Status using * (asterisk) and _ (underscore) signs.
  3. Observe that the text enclosed within * (asterisk) marks will be displayed in bold

Further comments

For now, I have successfully tested this with input containing * (asterisk) and _ (underscore) signs. It would be better if I could have more test cases.

@Kishn0109 Kishn0109 requested a review from a team as a code owner June 8, 2024 16:19
Copy link

changeset-bot bot commented Jun 8, 2024

🦋 Changeset detected

Latest commit: 5814d01

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/ddp-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Jun 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.40%. Comparing base (f20be47) to head (5814d01).
Report is 10 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #32574   +/-   ##
========================================
  Coverage    59.40%   59.40%           
========================================
  Files         2543     2543           
  Lines        63183    63179    -4     
  Branches     14220    14219    -1     
========================================
- Hits         37533    37532    -1     
+ Misses       22934    22931    -3     
  Partials      2716     2716           

@csuadev csuadev self-assigned this Jun 11, 2024
@csuadev
Copy link
Contributor

csuadev commented Jun 11, 2024

Hey, thanks for your contribution, I was testing it and it fixes the issue with bold and one italic but not the other one, these text *test* _test_ __test__ in our custom markdown should look like this, the __text__ also needs to be italic.

test test test

@Kishn0109
Copy link
Contributor Author

Kishn0109 commented Jun 11, 2024

Screen.Recording.-.Jun.11.2024.1.mp4

@csuadev I have test the updated code with the specified markdown inputs to ensure all cases are handled correctly.

csuadev
csuadev previously approved these changes Jun 12, 2024
Copy link
Contributor

@csuadev csuadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@csuadev csuadev added stat: QA tested stat: QA assured Means it has been tested and approved by a company insider labels Jun 12, 2024
Copy link
Member

@MarcosSpessatto MarcosSpessatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add tests to ensure the behavior? cc @csuadev

.changeset/kind-drinks-joke.md Outdated Show resolved Hide resolved
Co-authored-by: Marcos Spessatto Defendi <[email protected]>
@csuadev
Copy link
Contributor

csuadev commented Jul 26, 2024

I opened a PR with some tests for the component to ensure it renders the html elements as expected: #32914

@MarcosSpessatto MarcosSpessatto added this to the 6.12 milestone Aug 15, 2024
Copy link
Contributor

dionisio-bot bot commented Aug 15, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: QA tested labels Aug 15, 2024
@KevLehman KevLehman added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Aug 16, 2024
@csuadev csuadev added stat: QA assured Means it has been tested and approved by a company insider stat: QA tested stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge stat: QA assured Means it has been tested and approved by a company insider labels Aug 16, 2024
@KevLehman KevLehman added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Aug 16, 2024
@ggazzo ggazzo merged commit 6cb79a0 into RocketChat:develop Aug 21, 2024
47 of 50 checks passed
csuadev added a commit that referenced this pull request Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: QA tested stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
8 participants