-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Move Apps-Engine to monorepo #32951
Conversation
Looks like this PR is ready to merge! 🎉 |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32951 +/- ##
===========================================
+ Coverage 58.35% 59.38% +1.03%
===========================================
Files 2692 2556 -136
Lines 65265 63080 -2185
Branches 14730 14158 -572
===========================================
- Hits 38084 37459 -625
+ Misses 24403 22915 -1488
+ Partials 2778 2706 -72
Flags with carried forward coverage won't be shown. Click here to find out more. |
9cd07c8
to
da22fab
Compare
cb49a6e
to
f0fa128
Compare
cddb654
to
abdff2f
Compare
abdff2f
to
3d94f14
Compare
…ocket.Chat into feat/airgapped-restrictions * 'feat/airgapped-restrictions' of github.com:RocketChat/Rocket.Chat: (57 commits) fix: Async E2EE key exchange not working on develop (#33378) chore: Move Apps-Engine to monorepo (#32951) chore(Sidepanel): uses only local channels and discussions (#33387) chore: add gazzodown preview (#33279) fix: Avoid notifying `watch.settings` on uncaught errors (#33376) fix: race condition when forwarding livechat by splitting subscription removal (#33381) chore: Single Contact ID: improved typings and removed some duplicated code (#33324) ci: remove Jira-GitHub security integration (#33384) chore: add ui-composer to storybook (#33383) regression: `Sidepanel` sort requires refresh after room update (#33370) ci: use node20 for release action (#33343) Bump rocket.chat to 6.14.0-develop (#33366) chore: replace Meteor._localStorage -> Accounts.storageLocation (#33356) Release 6.13.0-rc.1 fix: Avoid destructuring `connectionData` when value is undefined (#33339) feat: Adds new admin feature preview setting management (#33212) regression: `Sidepanel` color highlight (#33342) chore: move common files to core-services (#33341) feat: Adds new admin feature preview setting management (#33212) chore: create network broker package (#33338) ...
…ocket.Chat into airgapped/composer-restriction * 'feat/airgapped-restrictions' of github.com:RocketChat/Rocket.Chat: (27 commits) review fix: skip invalid test for now consolidate restriction logic inside module remove constant from restriction module fix changeset Move tests to test folder remove wrong import fix proxyquire for airGappedRestrictionsCheck.ts test fix fix: Async E2EE key exchange not working on develop (#33378) Fix airgappedRestrictionswrapper tests Fix airgappedRestrictionCheck tests undo fix AirGappedRestriction logic Update logic and tests chore: Move Apps-Engine to monorepo (#32951) chore(Sidepanel): uses only local channels and discussions (#33387) chore: add gazzodown preview (#33279) wip fix: Avoid notifying `watch.settings` on uncaught errors (#33376) ...
Proposed changes (including videos or screenshots)
Move the Apps-Engine repo (https://github.com/RocketChat/Rocket.Chat.Apps-Engine) to the core monorepo (https://github.com/RocketChat/Rocket.Chat)
This will allow for a much smoother developer experience when adding features to the engine, as it won't be necessary anymore to wait for merges on one repo to then get other PR merged, and also we won't have conflicts anymore if something is merged on the engine side but not on the core side.
Benefits
Drawbacks
Considerations
What to do with issues and PRs on the Apps-Engine repo?
What do we do with the API reference? Currently it is hosted in github.io. Can we just port it?
What do we need to adapt here for Codecov?
Issue(s)
Steps to test or reproduce
Further comments
https://rocketchat.atlassian.net/browse/CONN-308
As of now, the apps-engine cannot executedeno
without a global installation in the system (e.g. the binary being available/bin/deno
). This seemed to start after Meteor's update to their own Node patch 14.21.4This was because we were overriding the ENV for the process and weren't passing a
PATH
, which causes the system to be unable to find thedeno
executable. It never happened before because previously we were using thedeno-bin
package to install deno and so we knew the direct path to the executable and didn't need to rely on thePATH
environment variable.Note for reviewers
Most of the files introduced by this PR already exist and are part of the
@rocket.chat/apps-engine
package - meaning they don't need further review, as they're just being moved. The important files to keep an eye out for are the ones outside of thepackages/apps-engine
folder, thepackages/apps-engine/package.json
file itself and whatever scripts it references, as those integrate the new package into the rest of the monorepo ecosystem.In order words, don't be frightened by the amount of files 🙈