fix: Async E2EE key exchange not working on develop #33378
Merged
+19
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: d88d88c The changes in this PR will be included in the next version bump. This PR includes changesets to release 33 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #33378 +/- ##
========================================
Coverage 58.35% 58.35%
========================================
Files 2692 2692
Lines 65265 65265
Branches 14730 14730
========================================
Hits 38084 38084
Misses 24403 24403
Partials 2778 2778
Flags with carried forward coverage won't be shown. Click here to find out more. |
ricardogarim
approved these changes
Sep 27, 2024
KevLehman
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
kodiakhq
bot
deleted the
fix/async-e2e-key-exchange-not-working-on-dev
branch
gabriellsh
added a commit
that referenced
this pull request
Sep 30, 2024
…ocket.Chat into feat/airgapped-restrictions * 'feat/airgapped-restrictions' of github.com:RocketChat/Rocket.Chat: (57 commits) fix: Async E2EE key exchange not working on develop (#33378) chore: Move Apps-Engine to monorepo (#32951) chore(Sidepanel): uses only local channels and discussions (#33387) chore: add gazzodown preview (#33279) fix: Avoid notifying `watch.settings` on uncaught errors (#33376) fix: race condition when forwarding livechat by splitting subscription removal (#33381) chore: Single Contact ID: improved typings and removed some duplicated code (#33324) ci: remove Jira-GitHub security integration (#33384) chore: add ui-composer to storybook (#33383) regression: `Sidepanel` sort requires refresh after room update (#33370) ci: use node20 for release action (#33343) Bump rocket.chat to 6.14.0-develop (#33366) chore: replace Meteor._localStorage -> Accounts.storageLocation (#33356) Release 6.13.0-rc.1 fix: Avoid destructuring `connectionData` when value is undefined (#33339) feat: Adds new admin feature preview setting management (#33212) regression: `Sidepanel` color highlight (#33342) chore: move common files to core-services (#33341) feat: Adds new admin feature preview setting management (#33212) chore: create network broker package (#33338) ...
KevLehman
added a commit
that referenced
this pull request
Sep 30, 2024
KevLehman
added a commit
that referenced
this pull request
Sep 30, 2024
This reverts commit dcc98fbeb8ec2f4c09982aebb665382577394720.
|
this title 💩 if its only in develop, it should be a regression, and if only happens in develop its not a real problem ;) |
|
Actually was on "development environments" because of Diego's changes not in prod yet lel The changeset had the proper text, which is a win. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
This was due to missing notifiers on development. As these notifiers are not used in production, we didn't have this problem yet.
Issue(s)
https://rocketchat.atlassian.net/browse/E2EE2-70
Steps to test or reproduce
Further comments