Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add references to room.info endpoint #33011

Merged
merged 39 commits into from
Sep 5, 2024

Conversation

sampaiodiego
Copy link
Member

@sampaiodiego sampaiodiego commented Aug 8, 2024

Proposed changes (including videos or screenshots)

rooms.info endpoint will now include:
parent: Represents the parent of a room. For discussions this is the room where the discussion was created, identified by prid. For rooms inside a team, the parent will be the team's main room, identified by team.roomId. For other rooms, this property is undefined.
team: Represents the team a room is part of. For rooms inside a team, this is the team identified by teamId property. For everything else, this is undefined.

Issue(s)

https://rocketchat.atlassian.net/browse/SIDE-155

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Aug 8, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Aug 8, 2024

🦋 Changeset detected

Latest commit: 4731573

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Minor
@rocket.chat/core-services Minor
@rocket.chat/rest-typings Minor
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/api-client Patch
@rocket.chat/ddp-client Patch
@rocket.chat/ui-contexts Major
@rocket.chat/livechat Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/gazzodown Major
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Major
@rocket.chat/core-typings Minor
@rocket.chat/apps Patch
@rocket.chat/cron Patch
@rocket.chat/model-typings Patch
@rocket.chat/license Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/models Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Aug 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.32%. Comparing base (e4e8541) to head (4731573).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #33011   +/-   ##
========================================
  Coverage    59.32%   59.32%           
========================================
  Files         2547     2547           
  Lines        63346    63346           
  Branches     14254    14254           
========================================
  Hits         37581    37581           
  Misses       23062    23062           
  Partials      2703     2703           
Flag Coverage Δ
unit 75.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@KevLehman KevLehman added this to the 6.13 milestone Aug 29, 2024
@KevLehman KevLehman marked this pull request as ready for review August 29, 2024 20:44
@KevLehman KevLehman requested review from a team as code owners August 29, 2024 20:44
Copy link
Member

@MarcosSpessatto MarcosSpessatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove all the front-end related changes?

Also, we need to add a changeset.

@ivans-netto
Copy link

@MarcosSpessatto @KevLehman If you remove front-end related changes, please add through another PR. Julia can clarify why they're important.

@KevLehman
Copy link
Contributor

Yep, changes will be part of a separate PR.

@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge stat: QA assured Means it has been tested and approved by a company insider and removed stat: QA tested labels Sep 3, 2024
@MarcosSpessatto MarcosSpessatto removed the request for review from a team September 5, 2024 09:32
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Sep 5, 2024
@KevLehman KevLehman added the stat: ready to merge PR tested and approved waiting for merge label Sep 5, 2024
@kodiakhq kodiakhq bot merged commit 532f088 into develop Sep 5, 2024
50 checks passed
@kodiakhq kodiakhq bot deleted the improve-rooms-info-endpoint branch September 5, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants