-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: promote roomUpdater to afterSaveMessage hook #33034
Conversation
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #33034 +/- ##
===========================================
- Coverage 59.40% 59.39% -0.01%
===========================================
Files 2541 2541
Lines 63180 63178 -2
Branches 14221 14220 -1
===========================================
- Hits 37530 37527 -3
Misses 22935 22935
- Partials 2715 2716 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
Co-authored-by: Guilherme Gazzo <[email protected]>
This pull request addresses the requirements of OPI-33 by promoting updater support to the
afterSaveMessage
hook - that aims to optimize performance by reducing database calls related to rooms and omnichannel rooms.