Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: promote roomUpdater to afterSaveMessage hook #33034

Merged
merged 10 commits into from
Aug 15, 2024

Conversation

ricardogarim
Copy link
Contributor

@ricardogarim ricardogarim commented Aug 13, 2024

This pull request addresses the requirements of OPI-33 by promoting updater support to the afterSaveMessage hook - that aims to optimize performance by reducing database calls related to rooms and omnichannel rooms.

Copy link
Contributor

dionisio-bot bot commented Aug 13, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Aug 13, 2024

⚠️ No Changeset found

Latest commit: 0c32c93

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.39%. Comparing base (ec0cec6) to head (0c32c93).
Report is 4 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #33034      +/-   ##
===========================================
- Coverage    59.40%   59.39%   -0.01%     
===========================================
  Files         2541     2541              
  Lines        63180    63178       -2     
  Branches     14221    14220       -1     
===========================================
- Hits         37530    37527       -3     
  Misses       22935    22935              
- Partials      2715     2716       +1     
Flag Coverage Δ
unit 76.02% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ricardogarim ricardogarim marked this pull request as ready for review August 15, 2024 15:54
@ricardogarim ricardogarim requested review from a team as code owners August 15, 2024 15:54
@ggazzo ggazzo added this to the 6.12 milestone Aug 15, 2024
@ggazzo ggazzo merged commit c7bdb14 into develop Aug 15, 2024
50 checks passed
@ggazzo ggazzo deleted the chore/roomUpdater.afterSaveMessage branch August 15, 2024 17:41
abhinavkrin pushed a commit that referenced this pull request Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants