fix: correct parameter order in afterSaveMessage to restore outgoing webhooks and related features

[ricardogarim]

After upgrading from Rocket.Chat version 6.9.0 to 6.12.0, outgoing integrations stopped functioning. The root cause was traced to a change in the parameter order passed by the afterSendMessage callback to the sendMessage event from the integrations app triggers. Specifically, the room parameter was not forwarded correctly, resulting in errors when searching for outgoing webhook triggers.

This issue was introduced by PR #33034, which modified the afterSaveMessage parameter signature but did not update the corresponding integration logic.

As outlined in SUP-665, this malfunction blocked the propagation of certain actions due to the callback failing to forward the correct parameters.

This PR resolves the issue by correcting the parameter order, ensuring the room parameter is passed correctly, thus restoring the functionality of outgoing webhooks.

Additionally, the same issue affected the following areas, which have now been fixed:

• IRC Bridge: Fixed an issue where the service failed to bind Rocket.Chat users with their correct IRC nickname or channel path.
• Autotranslate: Resolved an issue preventing messages from being automatically translated.
• EngagementDashboard: Corrected the issue where new messages were not being counted in the engagement dashboard.

[dionisio-bot]

Looks like this PR is not ready to merge, because of the following issues:

• This PR is targeting the wrong base branch. It should target 6.12.0, but it targets 6.13.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

[changeset-bot]

🦋 Changeset detected

Latest commit: 5c6f124

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 28 packages

Name	Type
@rocket.chat/meteor	Patch
@rocket.chat/core-typings	Patch
@rocket.chat/rest-typings	Patch
@rocket.chat/api-client	Patch
@rocket.chat/apps	Patch
@rocket.chat/core-services	Patch
@rocket.chat/cron	Patch
@rocket.chat/ddp-client	Patch
@rocket.chat/fuselage-ui-kit	Patch
@rocket.chat/gazzodown	Patch
@rocket.chat/livechat	Patch
@rocket.chat/model-typings	Patch
@rocket.chat/ui-contexts	Patch
@rocket.chat/account-service	Patch
@rocket.chat/authorization-service	Patch
@rocket.chat/ddp-streamer	Patch
@rocket.chat/omnichannel-transcript	Patch
@rocket.chat/presence-service	Patch
@rocket.chat/queue-worker	Patch
@rocket.chat/stream-hub-service	Patch
@rocket.chat/license	Patch
@rocket.chat/omnichannel-services	Patch
@rocket.chat/pdf-worker	Patch
@rocket.chat/presence	Patch
rocketchat-services	Patch
@rocket.chat/uikit-playground	Patch
@rocket.chat/models	Patch
@rocket.chat/instance-status	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-09-17 14:06 UTC

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.70%. Comparing base (b919221) to head (5c6f124).
Report is 1 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #33295   +/-   ##
========================================
  Coverage    59.70%   59.70%           
========================================
  Files         2551     2551           
  Lines        62792    62792           
  Branches     14102    14102           
========================================
  Hits         37492    37492           
  Misses       22893    22893           
  Partials      2407     2407           

Flag	Coverage Δ
unit	76.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

[scuciatto]

/patch

[dionisio-bot]

Pull request #33304 added to Project: "undefined"