fix: Forget session on window close #33040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 9997420 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #33040 +/- ##
========================================
Coverage 59.43% 59.43%
========================================
Files 2546 2546
Lines 63257 63257
Branches 14236 14236
========================================
Hits 37596 37596
Misses 22941 22941
Partials 2720 2720
Flags with carried forward coverage won't be shown. Click here to find out more. |
yash-rajpal
commented
Aug 13, 2024
MarcosSpessatto
requested changes
Aug 14, 2024
apps/meteor/tests/e2e/account-forgetSessionOnWindowClose.spec.ts
Outdated
Show resolved
Hide resolved
apps/meteor/tests/e2e/account-forgetSessionOnWindowClose.spec.ts
Outdated
Show resolved
Hide resolved
apps/meteor/tests/e2e/account-forgetSessionOnWindowClose.spec.ts
Outdated
Show resolved
Hide resolved
apps/meteor/tests/e2e/account-forgetSessionOnWindowClose.spec.ts
Outdated
Show resolved
Hide resolved
MarcosSpessatto
previously approved these changes
Aug 14, 2024
apps/meteor/tests/e2e/account-forgetSessionOnWindowClose.spec.ts
Outdated
Show resolved
Hide resolved
jessicaschelly
approved these changes
Aug 20, 2024
jessicaschelly
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
MarcosSpessatto
requested changes
Aug 21, 2024
MarcosSpessatto
approved these changes
Aug 21, 2024
dougfabris
approved these changes
Aug 21, 2024
|
/patch |
|
Pull request #33129 added to Project: "Patch 6.11.2" |
|
/backport 6.10.5 |
|
Pull request #33130 added to Project: "Patch 6.10.5" |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
We have a setting to use session storage on browser instead of local storage, so that browser forgets the session after window close. Everything was working fine till we upgraded to meteor 2.16 version.
The new meteor 2.16 release introduced a new option to configure the Accounts package and choose between the local storage or session storage. They also changed how
Meteor._localstorageworks internally. Due to these changes in Meteor, our setting to use session storage wasn't working as expected.This PR fixes this issue and configures the Accounts package according to the workspace settings.
Issue(s)
Steps to test or reproduce
Further comments
SUP-639