Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Forget session on window close #33129

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Conversation

dionisio-bot[bot]
Copy link
Contributor

@dionisio-bot dionisio-bot bot commented Aug 22, 2024

Backport of #33040

@dionisio-bot dionisio-bot bot requested a review from a team as a code owner August 22, 2024 17:47
Copy link

changeset-bot bot commented Aug 22, 2024

🦋 Changeset detected

Latest commit: c403c99

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dionisio-bot dionisio-bot bot added this to the 6.11 milestone Aug 22, 2024
Copy link
Contributor Author

dionisio-bot bot commented Aug 22, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.64%. Comparing base (9e1b9ad) to head (c403c99).
Report is 1 commits behind head on release-6.11.2.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           release-6.11.2   #33129      +/-   ##
==================================================
+ Coverage           55.62%   55.64%   +0.01%     
==================================================
  Files                2636     2636              
  Lines               57507    57513       +6     
  Branches            11934    11936       +2     
==================================================
+ Hits                31991    32005      +14     
+ Misses              22797    22788       -9     
- Partials             2719     2720       +1     
Flag Coverage Δ
e2e 54.35% <100.00%> (+0.03%) ⬆️
unit 71.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@scuciatto scuciatto added the stat: QA assured Means it has been tested and approved by a company insider label Aug 26, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Aug 26, 2024
@kodiakhq kodiakhq bot merged commit 3d01990 into release-6.11.2 Aug 26, 2024
54 of 55 checks passed
@kodiakhq kodiakhq bot deleted the backport-6.11.2-33040 branch August 26, 2024 14:30
@Domelus
Copy link

Domelus commented Sep 11, 2024

Still experiencing the issue. I have updated it to the latest version, 6.12.0.
After restarting the PC with the Rocket.chat client, logging into the interface is impossible, only 3 dots. Once I reboot the server, logging into the interface become possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants