Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Replaces outdated retention policy warning in favor of Bubble #33044

Merged
merged 3 commits into from
Aug 14, 2024

Conversation

dougfabris
Copy link
Member

@dougfabris dougfabris commented Aug 13, 2024

Proposed changes (including videos or screenshots)

before

Screenshot 2024-08-13 at 18 27 33

after

image

Issue(s)

Steps to test or reproduce

Further comments

CORE-576

Copy link
Contributor

dionisio-bot bot commented Aug 13, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Aug 13, 2024

🦋 Changeset detected

Latest commit: 2aee8df

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Minor
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/ddp-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/web-ui-registration Major
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dougfabris dougfabris added this to the 6.12 milestone Aug 13, 2024
@dougfabris dougfabris marked this pull request as ready for review August 14, 2024 00:05
@dougfabris dougfabris requested a review from a team as a code owner August 14, 2024 00:05
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Aug 14, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Aug 14, 2024
@ggazzo
Copy link
Member

ggazzo commented Aug 14, 2024

image

Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.40%. Comparing base (f882124) to head (2aee8df).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #33044      +/-   ##
===========================================
- Coverage    59.40%   59.40%   -0.01%     
===========================================
  Files         2541     2541              
  Lines        63181    63180       -1     
  Branches     14222    14221       -1     
===========================================
- Hits         37531    37530       -1     
  Misses       22935    22935              
  Partials      2715     2715              
Flag Coverage Δ
unit 76.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@kodiakhq kodiakhq bot merged commit 1b30512 into develop Aug 14, 2024
51 of 73 checks passed
@kodiakhq kodiakhq bot deleted the feat/retentionPolicyWarning branch August 14, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants