Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: Retention policy warning not truncating text #33186

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

dougfabris
Copy link
Member

@dougfabris dougfabris commented Aug 29, 2024

Introduced here: #33044

Proposed changes (including videos or screenshots)

before

Screenshot 2024-08-29 at 19 50 58

after

Screenshot 2024-08-29 at 18 33 55

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Aug 29, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Aug 29, 2024

⚠️ No Changeset found

Latest commit: 168d0c4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dougfabris dougfabris changed the title regression: RetentionPolicyWarning not truncating text regression: Retention policy warning not truncating text Aug 29, 2024
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.39%. Comparing base (0bfba5b) to head (168d0c4).
Report is 1 commits behind head on release-6.12.0.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           release-6.12.0   #33186   +/-   ##
===============================================
  Coverage           59.39%   59.39%           
===============================================
  Files                2548     2548           
  Lines               63551    63551           
  Branches            14350    14350           
===============================================
  Hits                37744    37744           
  Misses              23072    23072           
  Partials             2735     2735           
Flag Coverage Δ
unit 75.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo marked this pull request as ready for review August 29, 2024 23:57
@ggazzo ggazzo requested a review from a team as a code owner August 29, 2024 23:57
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Aug 29, 2024
@ggazzo ggazzo added this to the 6.12 milestone Aug 29, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Aug 29, 2024
@kodiakhq kodiakhq bot merged commit 54eff23 into release-6.12.0 Aug 30, 2024
53 of 54 checks passed
@kodiakhq kodiakhq bot deleted the regression/retention-policy-truncate branch August 30, 2024 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants