Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remaining realtime charts to TS #33111

Open
wants to merge 19 commits into
base: develop
Choose a base branch
from
Open

refactor: remaining realtime charts to TS #33111

wants to merge 19 commits into from
+209 −133

Conversation

MartinSchoeler
Copy link
Contributor

@MartinSchoeler MartinSchoeler commented Aug 20, 2024 •
edited
Loading

Issue(s)

https://rocketchat.atlassian.net/browse/CORE-633

Steps to test or reproduce

Further comments

Depends on #33092

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 20, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 1b469ac

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dionisio-bot dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Aug 20, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@codecov Codecov
Copy link

codecov bot commented Aug 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.33%. Comparing base (bb94c9c) to head (213d47b).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #33111   +/-   ##
========================================
  Coverage    59.33%   59.33%           
========================================
  Files         2546     2546           
  Lines        63245    63245           
  Branches     14220    14223    +3     
========================================
+ Hits         37527    37528    +1     
+ Misses       23016    23015    -1     
  Partials      2702     2702
Flag Coverage Δ
unit 75.47% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Base automatically changed from chart-ts-2 to develop August 23, 2024 15:10
@MartinSchoeler MartinSchoeler marked this pull request as ready for review August 23, 2024 16:28
@MartinSchoeler MartinSchoeler requested review from a team as code owners August 23, 2024 16:28
@MartinSchoeler MartinSchoeler marked this pull request as draft August 23, 2024 19:07
@dougfabris dougfabris changed the title refactor: Realtime Line Charts to TS #33092 refactor: Realtime Line Charts to TS Aug 23, 2024
@MartinSchoeler MartinSchoeler marked this pull request as ready for review August 26, 2024 12:55
@MartinSchoeler MartinSchoeler marked this pull request as draft September 2, 2024 12:52
@MartinSchoeler MartinSchoeler changed the title refactor: Realtime Line Charts to TS refactor: remaining realtime charts to TS Sep 2, 2024
@MartinSchoeler MartinSchoeler marked this pull request as ready for review September 5, 2024 13:04
MarcosSpessatto
MarcosSpessatto requested changes Sep 10, 2024
View reviewed changes
apps/meteor/app/livechat/client/lib/chartHandler.ts
@@ -108,7 +109,7 @@ const doughnutChartConfiguration = (

type ChartDataSet = {
label: string;
data: number;
data: number[];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this type change expected?

apps/meteor/app/livechat/client/lib/chartHandler.ts
@@ -128,12 +129,11 @@ export const drawLineChart = async (
chartContext: { destroy: () => void } | undefined,
chartLabels: string[],
dataLabels: string[],
dataSets: number[],
dataSets: number[][],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcosSpessatto MarcosSpessatto MarcosSpessatto requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MartinSchoeler @MarcosSpessatto @ggazzo