Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: NPS passing startAt as the expiration date when creating a banner #33155

Merged
merged 3 commits into from
Sep 6, 2024

Merge branch 'develop' into fix/nps-create-banner-passing-wrong-expir…

e246c3b
Select commit
Loading
Failed to load commit list.
Merged

fix: NPS passing startAt as the expiration date when creating a banner #33155

Merge branch 'develop' into fix/nps-create-banner-passing-wrong-expir…
e246c3b
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 6, 2024 in 0s

59.32% (-0.02%) compared to cd0d500

View this Pull Request on Codecov

59.32% (-0.02%) compared to cd0d500

Details

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.32%. Comparing base (cd0d500) to head (e246c3b).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #33155      +/-   ##
===========================================
- Coverage    59.33%   59.32%   -0.02%     
===========================================
  Files         2548     2548              
  Lines        63363    63415      +52     
  Branches     14252    14268      +16     
===========================================
+ Hits         37598    37622      +24     
- Misses       23062    23090      +28     
  Partials      2703     2703