Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Infinite loading when uploading a private app #33181

Merged
merged 7 commits into from
Sep 11, 2024
Merged

Conversation

MartinSchoeler
Copy link
Contributor

@MartinSchoeler MartinSchoeler commented Aug 29, 2024

Proposed changes (including videos or screenshots)

Fixes issue that causes infinite loading due an uncatched error when uploading invalid zip files
Fixes issue that causes infinite loading when opening a upsell modal

Issue(s)

PASLR-1

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Aug 29, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Aug 29, 2024

🦋 Changeset detected

Latest commit: f55b0dc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.73%. Comparing base (9ef096f) to head (f55b0dc).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #33181   +/-   ##
========================================
  Coverage    59.73%   59.73%           
========================================
  Files         2548     2548           
  Lines        63073    63073           
  Branches     14090    14090           
========================================
  Hits         37679    37679           
  Misses       22978    22978           
  Partials      2416     2416           
Flag Coverage Δ
unit 76.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@MartinSchoeler MartinSchoeler changed the title fix: Infinite loading when uploading an invalid zip app fix: Infinite loading when uploading a private app Aug 29, 2024
@MartinSchoeler MartinSchoeler added this to the 6.13 milestone Aug 29, 2024
@MartinSchoeler MartinSchoeler marked this pull request as ready for review August 29, 2024 19:10
@MartinSchoeler MartinSchoeler requested a review from a team as a code owner August 29, 2024 19:10
Copy link
Member

@dougfabris dougfabris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge stat: QA assured Means it has been tested and approved by a company insider and removed stat: QA tested labels Sep 10, 2024
@MartinSchoeler MartinSchoeler added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Sep 10, 2024
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Sep 10, 2024
@MartinSchoeler MartinSchoeler added the stat: ready to merge PR tested and approved waiting for merge label Sep 11, 2024
Copy link
Contributor

github-actions bot commented Sep 11, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-09-11 18:24 UTC

@kodiakhq kodiakhq bot merged commit fa8ac7a into develop Sep 11, 2024
50 checks passed
@kodiakhq kodiakhq bot deleted the apps-install-error branch September 11, 2024 18:22
gabriellsh added a commit that referenced this pull request Sep 11, 2024
…hAvatarById

* 'develop' of github.com:RocketChat/Rocket.Chat:
  fix: Infinite loading when uploading a private app (#33181)
  chore: publish preview github pages (#33248)
  chore: move playground (#33260)
  chore: E2EE setting warning update (#33224)
  fix: message parser being slow to process very long messages with too many symbols (#33227)
  chore: fix ui-playground build (#33250)
  feat: Option to disable 2FA for OAuth users (#32945)
  fix: Allow to use the token from `room.v` when requesting transcript instead of finding visitor (#33211)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants