Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Infinite loading when uploading a private app #33181

Merged
merged 7 commits into from
Sep 11, 2024
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/wet-hats-walk.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@rocket.chat/meteor": patch
---

Fixed issue that caused an infinite loading state when uploading a private app to Rocket.Chat
Original file line number Diff line number Diff line change
Expand Up @@ -114,8 +114,12 @@ export const useInstallApp = (file: File, url: string): { install: () => void; i
};

const extractManifestFromAppFile = async (appFile: File) => {
const manifest = await getManifestFromZippedApp(appFile);
return manifest;
try {
const manifest = await getManifestFromZippedApp(appFile);
dougfabris marked this conversation as resolved.
Show resolved Hide resolved
return manifest;
dougfabris marked this conversation as resolved.
Show resolved Hide resolved
} catch (error) {
handleInstallError(error as Error);
}
};

const install = async () => {
Expand Down Expand Up @@ -158,6 +162,7 @@ export const useInstallApp = (file: File, url: string): { install: () => void; i
handleEnableUnlimitedApps={() => {
openExternalLink(manageSubscriptionUrl);
setModal(null);
setInstalling(false);
}}
/>,
);
Expand Down
Loading