-
-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: Dropping support for python 3.7 #365
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please keep in mind that this will cause conflicts with #368
In the next days I am going to create some codespaces (https://docs.github.com/en/codespaces/getting-started/deep-dive) to test the package build under different operational systems, dependency and python versions. I'm also curious with this last comment: #265 (comment) |
@MateusStano , this one is ready for a re-review. RocketPy will always be built considering the requirements described in the setup.py file; I may open another PR to bump up netcdf requirement to 1.6.4 version. Until that, the code should be working properly regardless the OS or python version, as you can see by the successful github workflow tests. |
…irement MAINT: upgrade netcdf4 requirement
Update requirements.rst
This one is ready for review and merge! |
Co-authored-by: phmbressan <[email protected]>
Moving forward given that all the commentaries from both reviews were addressed already. |
Pull request type
Please check the type of change your PR introduces:
Pull request checklist
Please check if your PR fulfills the following requirements, depending on the type of PR:
ReadMe, Docs and GitHub maintenance:
What is the current behavior?
RocketPy supports python 3.7, which will stop being maintained/updated in the very-short-near future.
Considering that the v1.0.0 is probably going to be release later than that, I'm already proposing to drop python 3.7 support.
What is the new behavior?
Does this introduce a breaking change?
Other information