Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Dropping support for python 3.7 #365

Merged
merged 9 commits into from
Jun 18, 2023
Merged

Conversation

Gui-FernandesBR
Copy link
Member

Pull request type

Please check the type of change your PR introduces:

  • GitHub maintenance

Pull request checklist

Please check if your PR fulfills the following requirements, depending on the type of PR:

  • ReadMe, Docs and GitHub maintenance:

    • Spelling has been verified
    • Code docs are working correctly

What is the current behavior?

RocketPy supports python 3.7, which will stop being maintained/updated in the very-short-near future.
Considering that the v1.0.0 is probably going to be release later than that, I'm already proposing to drop python 3.7 support.

What is the new behavior?

  • The lowest version accepted to run rocketpy package is now the 3.8
  • The automations were adjusted to be run considering py 3.8
  • When modifying requirements, I used the same logic as before, but changing 3.7 to 3.8

Does this introduce a breaking change?

  • No

Other information

  • Only 1 month and 3 days left for the official support of python 3.7 (https://endoflife.date/python)
  • Sorry for the blank spaces added in some automation files, it was done automatically by the prettier.
  • The official drop will happen, automatically, only after making the release

@Gui-FernandesBR Gui-FernandesBR added Bug Something isn't working C.I. Continuous Integration (Workflows and actions) labels May 26, 2023
@Gui-FernandesBR Gui-FernandesBR added this to the Release v1.0.0 milestone May 26, 2023
@Gui-FernandesBR Gui-FernandesBR self-assigned this May 26, 2023
setup.py Outdated Show resolved Hide resolved
requirements.txt Outdated Show resolved Hide resolved
Copy link
Member

@MateusStano MateusStano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep in mind that this will cause conflicts with #368

docs/user/requirements.rst Outdated Show resolved Hide resolved
requirements.txt Outdated Show resolved Hide resolved
@Gui-FernandesBR
Copy link
Member Author

In the next days I am going to create some codespaces (https://docs.github.com/en/codespaces/getting-started/deep-dive) to test the package build under different operational systems, dependency and python versions.

I'm also curious with this last comment: #265 (comment)

@Gui-FernandesBR
Copy link
Member Author

@MateusStano , this one is ready for a re-review.

RocketPy will always be built considering the requirements described in the setup.py file;
Other files are used only for documentation purposes.
With that been said, if you agree with the changes made in the setup.py file, please notice that all the other files are simply following what is written in the setup.py.

I may open another PR to bump up netcdf requirement to 1.6.4 version. Until that, the code should be working properly regardless the OS or python version, as you can see by the successful github workflow tests.

@Gui-FernandesBR
Copy link
Member Author

This one is ready for review and merge!

docs/user/requirements.rst Outdated Show resolved Hide resolved
docs/user/requirements.rst Show resolved Hide resolved
@Gui-FernandesBR
Copy link
Member Author

Moving forward given that all the commentaries from both reviews were addressed already.

@Gui-FernandesBR Gui-FernandesBR merged commit deb35e1 into beta/v1.0.0 Jun 18, 2023
@Gui-FernandesBR Gui-FernandesBR deleted the maint/drop-py37 branch June 18, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working C.I. Continuous Integration (Workflows and actions)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants