Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: upgrade netcdf4 requirement #374

Merged
merged 2 commits into from
Jun 14, 2023

Conversation

Gui-FernandesBR
Copy link
Member

Pull request type

Please check the type of change your PR introduces:

  • Other (please describe): requirements update

Pull request checklist

Please check if your PR fulfills the following requirements, depending on the type of PR:

  • Code base maintenance (refactoring, formatting, renaming):

    • Docs have been reviewed and added / updated if needed
    • Lint (black rocketpy) has passed locally and any fixes were made
    • All tests (pytest --runslow) have passed locally

What is the current behavior?

The requirements for netcdf4 dependency is a bit more complex than what would be ideal. This has been a problem since the BUG #205 was reported.

What is the new behavior?

Everything is easier with the newest version of netcdf4, which may work without error all environments, including google colab.

Does this introduce a breaking change?

  • No

Other information

@Gui-FernandesBR Gui-FernandesBR added the Bug Something isn't working label Jun 9, 2023
@Gui-FernandesBR Gui-FernandesBR added this to the Release v1.0.0 milestone Jun 9, 2023
@Gui-FernandesBR Gui-FernandesBR self-assigned this Jun 9, 2023
@github-actions github-actions bot requested a review from MateusStano June 9, 2023 17:04
@Gui-FernandesBR Gui-FernandesBR linked an issue Jun 9, 2023 that may be closed by this pull request
Copy link
Member

@MateusStano MateusStano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one change here, everything else seems good

docs/user/requirements.rst Show resolved Hide resolved
@Gui-FernandesBR
Copy link
Member Author

Going to merge this one into maint/drop-py37, ad from there we merge into beta/v1.
I think that's a faster way

@Gui-FernandesBR Gui-FernandesBR merged commit 1b2c014 into maint/drop-py37 Jun 14, 2023
@Gui-FernandesBR Gui-FernandesBR deleted the maint/upgrade-netcdf4-requirement branch June 14, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RuntimeError: Unable to load latest weather data for GFS
2 participants