Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Julia 1.0 compat #37

Merged
merged 2 commits into from
Apr 15, 2021
Merged

Julia 1.0 compat #37

merged 2 commits into from
Apr 15, 2021

Conversation

fonsp
Copy link
Contributor

@fonsp fonsp commented Apr 15, 2021

After Roger-luo/ExproniconLite.jl#2, this package is already compatible with Julia 1.0. I changed the config bound to "1", and after Roger-luo/ExproniconLite.jl#2 is released, Julia's package manager will automatically make sure that 1.0 users get the working combination of packages.

Tests on 1.0 will fail right now, because Roger-luo/ExproniconLite.jl#2 is not yet released, so the dependency cannot be resolved.

@codecov
Copy link

codecov bot commented Apr 15, 2021

Codecov Report

Merging #37 (3dc366e) into master (8d71fd7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #37   +/-   ##
=======================================
  Coverage   92.93%   92.93%           
=======================================
  Files           8        8           
  Lines         382      382           
=======================================
  Hits          355      355           
  Misses         27       27           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d71fd7...3dc366e. Read the comment docs.

@Roger-luo Roger-luo closed this Apr 15, 2021
@Roger-luo Roger-luo reopened this Apr 15, 2021
@Roger-luo
Copy link
Owner

While fixing 1.0 compat issue in Expronicon, I was actually wondering about whether to support 1.0 and when do we drop 1.0 support - although Julia itself has a 1.0 LTS promise, it becomes harder and harder to support 1.0 with new compilation features for packages like Expronicon, and 1.0 has various issues when someone works with the compiler internals. This also happens to Expronicon, the generated code from @switch actually doesn't work in 1.0 somehow due to an undefined SSA variable error.

And I think, in fact, a lot of packages dropped 1.0 support a while ago, e.g most of the SciML packages only support 1.3+. Would it be a good idea to drop 1.0 support after the next LTS release? I'm wondering what would be the plan on Pluto side?

I'm releasing a schema checker package based on Configurations: https://github.com/Roger-luo/KungIChi.jl, and I'm planning not to support versions less than 1.6.

@Roger-luo Roger-luo closed this Apr 15, 2021
@Roger-luo Roger-luo reopened this Apr 15, 2021
@Roger-luo Roger-luo merged commit c0d2495 into Roger-luo:master Apr 15, 2021
@fonsp
Copy link
Contributor Author

fonsp commented Apr 15, 2021

Thanks! I try to support 1.0 for as long as possible, but I hope 1.6 will become LTS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants