Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Julia 1.0 compat #2

Closed
wants to merge 1 commit into from
Closed

Conversation

fonsp
Copy link

@fonsp fonsp commented Apr 15, 2021

I want to use Configurations.jl in Pluto, but we support Julia 1.0 and up, the compatibility of Configurations is bound to >=1.3. It seems like this package was the limiting factor.

@codecov
Copy link

codecov bot commented Apr 15, 2021

Codecov Report

Merging #2 (ce2be83) into master (ce11dc0) will decrease coverage by 0.56%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #2      +/-   ##
==========================================
- Coverage   80.19%   79.62%   -0.57%     
==========================================
  Files           6        6              
  Lines        2095     2120      +25     
==========================================
+ Hits         1680     1688       +8     
- Misses        415      432      +17     
Impacted Files Coverage Δ
src/ExproniconLite.jl 0.00% <ø> (ø)
src/analysis.jl 71.31% <0.00%> (-0.87%) ⬇️
src/transform.jl 83.62% <0.00%> (-0.38%) ⬇️
src/printing.jl 84.15% <0.00%> (-0.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce11dc0...ce2be83. Read the comment docs.

@fonsp
Copy link
Author

fonsp commented Apr 15, 2021

Configurations.jl passes on Julia 1.0 if this branch of ExproniconLite.jl is used! Yay

@Roger-luo
Copy link
Owner

Thanks, this package is generated by Expronicon (see https://discourse.julialang.org/t/ann-exproniconlite-jl-the-mlstyle-generated-dependency-free-package-for-low-latency/59247) to cover all the cases for var_str it would require a Julia parser update (JuliaLang/julia#32408) but I guess luckily MLStyle doesn't generate any corner cases, so we could make it compatible with 1.0 using this!

@Roger-luo
Copy link
Owner

This should be fixed in Roger-luo/Expronicon.jl@fe47408
the new patch release should be compatible with 1.0

@Roger-luo Roger-luo closed this Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants