Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes required for easy-ui5 integration of new TS features #645

Merged
merged 5 commits into from
Aug 29, 2022

Conversation

tobiasqueck
Copy link
Contributor

@tobiasqueck tobiasqueck commented Aug 29, 2022

Feature: #621
Required for: ui5-community/generator-ui5-project#58

  • Fixed incorrect id in Component.ts template when calling enableFpm
  • Enhanced tests to cover this case
  • Changed input for file ignore pattern to array to be compatible with older version of ejs (could happen if integrated in an older version of yeoman)

@changeset-bot
Copy link

changeset-bot bot commented Aug 29, 2022

🦋 Changeset detected

Latest commit: 942d2ac

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@sap-ux/fe-fpm-writer Patch
@sap-ux/fiori-elements-writer Patch
@sap-ux/generator-simple-fe Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tobiasqueck tobiasqueck changed the title Collection of fixes required for easy-ui5 integration of new TS features Small fix required for easy-ui5 integration of new TS features Aug 29, 2022
@tobiasqueck tobiasqueck marked this pull request as ready for review August 29, 2022 14:02
@tobiasqueck tobiasqueck requested a review from a team as a code owner August 29, 2022 15:18
@sonarcloud
Copy link

sonarcloud bot commented Aug 29, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

85.7% 85.7% Coverage
0.0% 0.0% Duplication

@tobiasqueck tobiasqueck changed the title Small fix required for easy-ui5 integration of new TS features Small fixes required for easy-ui5 integration of new TS features Aug 29, 2022
Copy link
Member

@devinea devinea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tobiasqueck
Changes look good.

Copy link
Contributor

@IainSAP IainSAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tobiasqueck tobiasqueck merged commit b76323d into main Aug 29, 2022
@tobiasqueck tobiasqueck deleted the ts-easyui5-integration branch August 29, 2022 16:15
@tobiasqueck tobiasqueck mentioned this pull request Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants