Utilizing the new TS support of open-ux-tools #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobiasqueck
requested review from
petermuessig,
vobu,
marianfoo and
nicoschoenteich
petermuessig
approved these changes
Sep 23, 2022
|
@tobiasqueck I just had some FYI comments and let you check them - I'm fine with the change, so if you wanna go ahead with the change we can merge it. |
|
@marianfoo @vobu @nicoschoenteich may I get a review from one of you? @petermuessig reviewed and approved but I'd prefer a 2nd review. |
|
Hi @tobiasqueck, thanks for all the work. I would love to do a review, but unfortunately am incredibly busy with Devtoberfest prep. I will have a look, once things calm down, but can't promise anything. |
Remove reference to ui5-tooling-modules in FPM TS support
MariusFreitag
approved these changes
Oct 12, 2022
nicoschoenteich
approved these changes
Dec 14, 2022
There was a problem hiding this comment.
Veery late to the party... But I think this is a great addition and we can go ahead and merge. Thanks @tobiasqueck!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest version of the
@sap-ux/ui5-application-writerand the@sap-ux/fe-fpm-writersupport the usage of Typescript based on the structure suggested by @petermuessig at https://github.com/ui5-community/ui5-ecosystem-showcase/tree/main/packages/ui5-app-ts.This PR enables the functionality for
easy-ui5.