Merge pull request #150 from SDP-Rock-Paper-Scissors/fix_leaderboard_…

…offline
SDP-Rock-Paper-Scissors · May 31, 2022 · 0cddcbb · 0cddcbb
2 parents 08ce3f3 + 5ff587f
commit 0cddcbb
Showing 1 changed file with 5 additions and 9 deletions.
diff --git a/app/src/main/java/ch/epfl/sweng/rps/ui/leaderboard/LeaderboardFragment.kt b/app/src/main/java/ch/epfl/sweng/rps/ui/leaderboard/LeaderboardFragment.kt
@@ -82,20 +82,16 @@ class LeaderboardFragment : Fragment() {
 
     private fun loadPlayersUI(itemView: View, players: List<LeaderBoardInfo>) {
         val champions = players.take(3)
-        showPlayersPosition(itemView, players)
         showChampions(itemView, champions)
+        showPlayersPosition(itemView, players)
 
     }
 
     private fun showChampions(itemView: View, championPlayers: List<LeaderBoardInfo>) {
-
-        itemView.findViewById<ImageView>(R.id.iv_champion1)
-            .load(championPlayers[0].userProfilePictureUrl)
-        itemView.findViewById<ImageView>(R.id.iv_champion2)
-            .load(championPlayers[1].userProfilePictureUrl)
-        itemView.findViewById<ImageView>(R.id.iv_champion3)
-            .load(championPlayers[2].userProfilePictureUrl)
-
+        val championImgViewList = listOf<ImageView>(itemView.findViewById(R.id.iv_champion1),itemView.findViewById(R.id.iv_champion2), itemView.findViewById(R.id.iv_champion3))
+        for ((i, championPlayer) in championPlayers.withIndex()) {
+            championImgViewList[i].load(championPlayer.userProfilePictureUrl)
+        }
     }
 
     private fun showPlayersPosition(