-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix offline leaderboard crash #150
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you should only display when there are more than 3, can't you only display like 1 or 2 when there are only that many ?
Thanks for your comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, can you use something,like this instead of using a separate var ?
for ((i, p) in championPlayers.withIndex()) {
// logic here
}
Yesss! Thanks for letting me know, it's more simplicity :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I found the crash reason is, that in offline mode, we have an empty player list, and I want to access the player avatar of the top 3, which will be out of the boundary.