Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Sphinx config #415

Merged
merged 15 commits into from
Jan 4, 2023
Merged

Conversation

CasperWA
Copy link
Collaborator

@CasperWA CasperWA commented Jan 4, 2023

Closes #400

This is a rather lengthy PR and may require several rounds of review.

The goal is to update the Sphinx configuration (conf.py) file and remove (or reduce as much as possible) the build warnings/errors. As the main part of these warnings are currently emitted from the auto-generated API documentation, this means updating the doc-strings where necessary.

The triplestore module has been stripped of everything except the units files.

Currently, the warnings/errors present pertain to these parts:

  1. Duplicate object descriptions.
  2. Files misplaced during build under share/dlite/mapping-plugins/.
  3. Unable to resolve cross-references to classes found in both dlite and dlite.dlite.

Concerning point 1, this is due to duplications in some methods or similar that are defined both in the C code and included Python files. Or it may be due to overloaded functions, something that Sphinx and AutoAPI cannot handle.

For point 2, this will be solved by #412.

The multiple cross-references in point 3 is something that may be fixable in this PR. I need to investigate this further.

CasperWA and others added 9 commits January 2, 2023 15:03
Update the requirements files, especially for the documentation.
Fix up the conf.py file for configuring the Sphinx build.
Add explicitly the AutoAPI templates.
Update the "homepage" index file to include a nicer ToC.
These tests are absolutely HORRIBLE!!!!
@CasperWA CasperWA requested a review from quaat January 4, 2023 11:18
Copy link
Collaborator

@quaat quaat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR addresses several (unrelated?) issues which could have been resolved in separate PRs. My suggestion is to approve this PR now, and create follow-up tasks.

@CasperWA
Copy link
Collaborator Author

CasperWA commented Jan 4, 2023

This PR addresses several (unrelated?) issues which could have been resolved in separate PRs. My suggestion is to approve this PR now, and create follow-up tasks.

Yeah. Bad practice, sorry. Some are a bit unrelated, most are indirectly related though.

@CasperWA
Copy link
Collaborator Author

CasperWA commented Jan 4, 2023

@daniel-sintef I have created #416 and #417 as follow-up tasks/issues. This should cover it for now?

@CasperWA CasperWA merged commit d894f9f into master Jan 4, 2023
@CasperWA CasperWA deleted the cwa/close-400-update-clean-sphinx-config branch January 4, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update and clean Sphinx configuration
2 participants