Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graphical representation of a Room #3

Open
Koldar opened this issue Sep 29, 2017 · 5 comments
Open

Graphical representation of a Room #3

Koldar opened this issue Sep 29, 2017 · 5 comments

Comments

@Koldar
Copy link
Collaborator

Koldar commented Sep 29, 2017

AS A player
I WANT to visually explore a room
BECAUSE it's really cool to explore a 3D environment

After completing #2 , we need to create a graphical representation of a room. We need to use the interface of the room, not the concrete class (eg. we need to use IRoom, not ConcreteClassRoom).

Everything needed to create the graphical representation of the room should reside in either a prefab referenced by the model or in the model themselves. I didn't think it well, but I personally think that a prefab might be cooler: we should have a "prefab" inside Unity, one per each room shape (eg. one for the rectangular shape, one for the ellptical one and son on). The model just reference the prefab needed an inside the model there are some fields specifying the width, length and height of the room (for the rectangular shape, for example).

Of course if you come up with a better model do it! :) Think how to attach the graphical representation of the room inside the unity environment well because it needs to be well thought!

So, when you can actually see in the game the room define in the maze, your task is done

@micheledusi
Copy link

Done first commit.
Created the room visualizer, which places tiles at the proper position to make the whole 3D model.

@Koldar
Copy link
Collaborator Author

Koldar commented Oct 27, 2017

Is the code completely achieve the task? If so tell me that I will review such code :)

micheledusi pushed a commit that referenced this issue Oct 27, 2017
- Re-created all the 3D models, to clean Blender project;
- Re-organized folders for textures and tile prefabs;
- Added few basic textures (not to overweigth the single tile);
- Imported from Blender three materials for room visualization;
- Added simple generation test at program starting;
- Added collision boxes to new prefabs;
- Completed Issue #3.
@micheledusi
Copy link

I'v just done the last commit for the alpha version; I described into the commits exactly what I've done and what is still missing.
If you want to review the code, feel free to do it; I provided some documentation hoping it can help to understand it (well, it's not so hard).

Notes:

  • In the task description, a "RoomInterface" is nominated; but in my code I preferred not to use it since (1) it seemed like there was no necessity for that, and (2) I've still no idea of what a "ConcreteClassRoom" would look like. I think, anyway, this vacancy would be easily solved once we'll put together every code piece.
  • This task requested me to create some models and prefabs. I realized, though, that there's not a proper way to document what I did, so I tried to explain my work in commits and in code's documentation. If you all think we need some sort of "guide" to let the others understand models and props (a "guide" which is not directly contained in code comments), let me know and we can think about a solution together.

@micheledusi
Copy link

I'm going to work again on this task after having changed all the room hierarchy, to adapt Factories classes into the new implementation.

@Koldar
Copy link
Collaborator Author

Koldar commented Nov 14, 2017

Ok! Good job! I can't wait to see the animated fountain!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants