Skip to content
This repository has been archived by the owner on Nov 29, 2023. It is now read-only.

fix(parser): don't create enums for union types #970

Merged
merged 3 commits into from
Jul 9, 2022

Conversation

lars-reimann
Copy link
Member

@lars-reimann lars-reimann commented Jul 9, 2022

Closes #966.

Summary of Changes

If we detect that a parameter has a union type, we no longer create an @enum annotation for it.

@lars-reimann lars-reimann linked an issue Jul 9, 2022 that may be closed by this pull request
@github-actions
Copy link

github-actions bot commented Jul 9, 2022

MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ CREDENTIALS secretlint yes no 3.34s
✅ GIT git_diff yes no 0.01s
✅ JSON eslint-plugin-jsonc 2 0 0 3.22s
✅ JSON jsonlint 2 0 1.0s
✅ JSON prettier 2 0 0 1.99s
✅ JSON v8r 2 0 1.93s
✅ PYTHON bandit 1 0 0.27s
✅ PYTHON black 1 0 0 0.32s
✅ PYTHON flake8 1 0 0.33s
✅ PYTHON isort 1 0 0 0.13s
✅ PYTHON mypy 1 0 7.76s
✅ PYTHON pylint 1 0 1.66s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

@lars-reimann lars-reimann merged commit 811338d into main Jul 9, 2022
@lars-reimann lars-reimann deleted the 966-dont-create-enums-for-union-types branch July 9, 2022 13:59
@github-actions
Copy link

github-actions bot commented Jul 9, 2022

🎉 This PR is included in version 1.57.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Included in a release label Jul 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
released Included in a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't create enums for union types
1 participant