Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add copy method for Tables #275

Closed
zzril opened this issue May 5, 2023 · 3 comments · Fixed by #405
Closed

Add copy method for Tables #275

zzril opened this issue May 5, 2023 · 3 comments · Fixed by #405
Assignees
@PhilipGutberlet @patrikguempel
Labels
cleanup 🧹 Refactorings and other tasks that improve the code released Included in a release

Comments

@zzril
Copy link
Contributor

zzril commented May 5, 2023 •
edited
Loading

Is your feature request related to a problem?

The Table and TaggedTable classes should have a dedicated private _copy() method.
This method is helpful for tests (e.g. when we want to verify that a method does not change the original table).
Also, a manual copy mechanism is currently implemented in several places. All of these occurrences should be found and be replaced by the new _copy() method.

These methods will not be intended for use by the end user.

One can consider also adding a copy method to the Row and Column classes.

Desired solution

Implement _copy() for Table and TaggedTable. Find occurrences of manual copying and replace to use the new method.
@zzril zzril added the enhancement 💡 New feature or request label May 5, 2023
@lars-reimann
Copy link
Member

Regarding the name: I'd vote for _copy.

@lars-reimann lars-reimann added cleanup 🧹 Refactorings and other tasks that improve the code and removed enhancement 💡 New feature or request labels May 7, 2023
@patrikguempel
Copy link
Contributor

used a copy dummy in table#remove_row and table#remove_rows

@patrikguempel patrikguempel self-assigned this Jun 30, 2023
@PhilipGutberlet PhilipGutberlet self-assigned this Jun 30, 2023
@patrikguempel patrikguempel linked a pull request Jun 30, 2023 that will close this issue
feat: Add copy method for tables #405
Merged
@patrikguempel patrikguempel mentioned this issue Jun 30, 2023
Merged
PhilipGutberlet added a commit that referenced this issue Jun 30, 2023
@patrikguempel @PhilipGutberlet
@megalinter-bot @Marsmaennchen221
feat: Add copy method for tables (#405)
72e87f0 
Closes #275 

### Summary of Changes
Added copy method for Table, TaggedTable, Row, Column and looked through
code to change usage to this method.

Co-authored-by: philipgutberlet
<[email protected]>

---------

Co-authored-by: PhilipGutberlet <[email protected]>
Co-authored-by: megalinter-bot <[email protected]>
Co-authored-by: Alexander <[email protected]>
lars-reimann pushed a commit that referenced this issue Jul 13, 2023
@semantic-release-bot
chore(release): 0.15.0 [skip ci]
a52bc18 
## [0.15.0](v0.14.0...v0.15.0) (2023-07-13)

### Features

* Add copy method for tables ([#405](#405)) ([72e87f0](72e87f0)), closes [#275](#275)
* add gaussian noise to image ([#430](#430)) ([925a505](925a505)), closes [#381](#381)
* add schema conversions when adding new rows to a table and schema conversion when creating a new table ([#432](#432)) ([6e9ff69](6e9ff69)), closes [#404](#404) [#322](#322) [#127](#127) [#322](#322) [#127](#127)
* add test for empty tables for the method `Table.sort_rows` ([#431](#431)) ([f94b768](f94b768)), closes [#402](#402)
* added color adjustment feature ([#409](#409)) ([2cbee36](2cbee36)), closes [#380](#380)
* added test_repr table tests ([#410](#410)) ([cb77790](cb77790)), closes [#349](#349)
* discretize table ([#327](#327)) ([5e3da8d](5e3da8d)), closes [#143](#143)
* Improve error handling of TaggedTable ([#450](#450)) ([c5da544](c5da544)), closes [#150](#150)
* Maintain tagging in methods inherited from `Table` class ([#332](#332)) ([bc73a6c](bc73a6c)), closes [#58](#58)
* new error class `OutOfBoundsError` ([#438](#438)) ([1f37e4a](1f37e4a)), closes [#262](#262)
* rename several `Table` methods for consistency ([#445](#445)) ([9954986](9954986)), closes [#439](#439)
* suggest similar columns if column gets accessed that doesnt exist ([#385](#385)) ([6a097a4](6a097a4)), closes [#203](#203)

### Bug Fixes

* added the missing ids in parameterized tests ([#412](#412)) ([dab6419](dab6419)), closes [#362](#362)
* don't warn if `Imputer` transforms column without missing values ([#448](#448)) ([f0cb6a5](f0cb6a5))
* Warnings raised by underlying seaborn and numpy libraries  ([#425](#425)) ([c4143af](c4143af)), closes [#357](#357)
@lars-reimann
Copy link
Member

🎉 This issue has been resolved in version 0.15.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PhilipGutberlet PhilipGutberlet

@patrikguempel patrikguempel

Labels
cleanup 🧹 Refactorings and other tasks that improve the code released Included in a release
Projects
Library
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add copy method for tables Safe-DS/Library
4 participants
@lars-reimann @zzril @PhilipGutberlet @patrikguempel