Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warnings raised by underlying seaborn and numpy libraries #357

Closed
zzril opened this issue Jun 11, 2023 · 4 comments · Fixed by #425
Closed

Warnings raised by underlying seaborn and numpy libraries #357

zzril opened this issue Jun 11, 2023 · 4 comments · Fixed by #425
Assignees
@jxnior01
Labels
cleanup 🧹 Refactorings and other tasks that improve the code released Included in a release

Comments

@zzril
Copy link
Contributor

zzril commented Jun 11, 2023 •
edited
Loading

Is your feature request related to a problem?

When running the test suite, currently 3 warnings will be raised from underlying libraries (seaborn and numpy) and are not catched.

These are the corresponding testcases:

  • tests/safeds/data/tabular/containers/_table/test_plot_correlation_heatmap.py::test_should_match_snapshot[empty]
  • tests/safeds/data/tabular/containers/_table/test_plot_correlation_heatmap.py::test_should_match_snapshot[empty]
  • tests/safeds/data/tabular/containers/_table/test_plot_histograms.py::test_should_match_snapshot[four columns]

For the first 2, the warnings are raised by some seaborn module and seems to have the same cause, the 3rd one is some numpy thing.

Desired solution

Ideal solution: Find the cause of the warnings and change the code to not produce these warnings anymore.

Possible alternatives (optional)

If it's absolutely clear that we can't do anything to fix these warnings:
Silence them in the code that produced them. (Not just in the tests!)
@zzril zzril added testing 🧪 Additional automated tests cleanup 🧹 Refactorings and other tasks that improve the code labels Jun 11, 2023
@zzril zzril changed the title Testing: Warnings from underlying libraries Testing: Warnings raised by underlying seaborn and numpy libraries Jun 11, 2023
@lars-reimann
Copy link
Member

We should configure Pytest to treat all warnings as errors (unless specifically ignored) in pyproject.toml, as described here.

@zzril zzril mentioned this issue Jun 27, 2023
Closed
@lars-reimann
Copy link
Member

How to ignore warnings: https://github.com/Safe-DS/Stdlib/blob/c5d75df0c6a548eafe9caef291f0360b28a1d548/src/safeds/data/tabular/containers/_table.py#L1932-L1937

@zzril zzril removed the testing 🧪 Additional automated tests label Jun 30, 2023
@zzril
Copy link
Contributor Author

zzril commented Jun 30, 2023 •
edited
Loading

Updated the description to state that we don't just want to silence the warnings in the tests, but in the code that throws them.

@zzril zzril changed the title Testing: Warnings raised by underlying seaborn and numpy libraries Warnings raised by underlying seaborn and numpy libraries Jun 30, 2023
@jxnior01 jxnior01 self-assigned this Jul 6, 2023
@jxnior01 jxnior01 mentioned this issue Jul 6, 2023
Merged
@jxnior01 jxnior01 linked a pull request Jul 6, 2023 that will close this issue
fix: Warnings raised by underlying seaborn and numpy libraries #425
Merged
Marsmaennchen221 added a commit that referenced this issue Jul 13, 2023
@jxnior01 @megalinter-bot @Marsmaennchen221
fix: Warnings raised by underlying seaborn and numpy libraries (#425)
c4143af 
Closes #357 

### Summary of Changes

* Python's `warnings` module now ignores warnings caused by underlying
seaborn and numpy libraries.

---------

Co-authored-by: megalinter-bot <[email protected]>
Co-authored-by: Alexander <[email protected]>
lars-reimann pushed a commit that referenced this issue Jul 13, 2023
@semantic-release-bot
chore(release): 0.15.0 [skip ci]
a52bc18 
## [0.15.0](v0.14.0...v0.15.0) (2023-07-13)

### Features

* Add copy method for tables ([#405](#405)) ([72e87f0](72e87f0)), closes [#275](#275)
* add gaussian noise to image ([#430](#430)) ([925a505](925a505)), closes [#381](#381)
* add schema conversions when adding new rows to a table and schema conversion when creating a new table ([#432](#432)) ([6e9ff69](6e9ff69)), closes [#404](#404) [#322](#322) [#127](#127) [#322](#322) [#127](#127)
* add test for empty tables for the method `Table.sort_rows` ([#431](#431)) ([f94b768](f94b768)), closes [#402](#402)
* added color adjustment feature ([#409](#409)) ([2cbee36](2cbee36)), closes [#380](#380)
* added test_repr table tests ([#410](#410)) ([cb77790](cb77790)), closes [#349](#349)
* discretize table ([#327](#327)) ([5e3da8d](5e3da8d)), closes [#143](#143)
* Improve error handling of TaggedTable ([#450](#450)) ([c5da544](c5da544)), closes [#150](#150)
* Maintain tagging in methods inherited from `Table` class ([#332](#332)) ([bc73a6c](bc73a6c)), closes [#58](#58)
* new error class `OutOfBoundsError` ([#438](#438)) ([1f37e4a](1f37e4a)), closes [#262](#262)
* rename several `Table` methods for consistency ([#445](#445)) ([9954986](9954986)), closes [#439](#439)
* suggest similar columns if column gets accessed that doesnt exist ([#385](#385)) ([6a097a4](6a097a4)), closes [#203](#203)

### Bug Fixes

* added the missing ids in parameterized tests ([#412](#412)) ([dab6419](dab6419)), closes [#362](#362)
* don't warn if `Imputer` transforms column without missing values ([#448](#448)) ([f0cb6a5](f0cb6a5))
* Warnings raised by underlying seaborn and numpy libraries  ([#425](#425)) ([c4143af](c4143af)), closes [#357](#357)
@lars-reimann
Copy link
Member

🎉 This issue has been resolved in version 0.15.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jxnior01 jxnior01

Labels
cleanup 🧹 Refactorings and other tasks that improve the code released Included in a release
Projects
Library
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Warnings raised by underlying seaborn and numpy libraries Safe-DS/Library
3 participants
@lars-reimann @zzril @jxnior01