Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(template): Set versioncontrol from golangci via go.mod #206

Closed
wants to merge 15 commits into from
Closed

fix(template): Set versioncontrol from golangci via go.mod #206

wants to merge 15 commits into from

Conversation

linuxluigi
Copy link
Collaborator

Set versioncontrol from golangci via go.mod

Depends on PR #198

@linuxluigi
Add govulncheck
457caa9 
Signed-off-by: Steffen Exler <[email protected]>
@linuxluigi
Fix CI
682d53c 
Signed-off-by: Steffen Exler <[email protected]>
@linuxluigi
Merge branch 'main' into feature/add-vulnerability-scanner
02f313c 
Signed-off-by: Steffen Exler <[email protected]>
@linuxluigi
fix makefile
867f638
@linuxluigi
add govulncheck installation into makefile
fa2e684
@linuxluigi
Remove phony
2a015dd 
Signed-off-by: Steffen Exler <[email protected]>
@linuxluigi
Add path to govulncheck command
67665ac 
Signed-off-by: Steffen Exler <[email protected]>
@linuxluigi
Set version of golangci via go.mod
86edd04 
Signed-off-by: Steffen Exler <[email protected]>
@linuxluigi
Fix adding golangci-lint bin to makefile
82e7b11 
Signed-off-by: Steffen Exler <[email protected]>
@linuxluigi
Fix golangci bin
61611c7 
Signed-off-by: Steffen Exler <[email protected]>
@linuxluigi
Fix makefile
e63cfa2 
Signed-off-by: Steffen Exler <[email protected]>
@linuxluigi
Run golangci with github action
0fdf816 
Signed-off-by: Steffen Exler <[email protected]>
@linuxluigi
Add doc entry
9928631 
Signed-off-by: Steffen Exler <[email protected]>
@linuxluigi
Add doc entry also for template
b3d23cc 
Signed-off-by: Steffen Exler <[email protected]>
@linuxluigi
Remove reports from make ci
0c3e8a7 
Signed-off-by: Steffen Exler <[email protected]>
brumhard
brumhard reviewed Feb 8, 2023
View reviewed changes
Copy link
Contributor

@brumhard brumhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the advantage of doing that in the action and not as part of the Makefile?

@linuxluigi
Copy link
Collaborator Author

Reject in favor of #243

@linuxluigi linuxluigi closed this Feb 10, 2023
@linuxluigi linuxluigi deleted the feature/golangci-version-control-in-tools branch April 14, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brumhard brumhard brumhard left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@linuxluigi @brumhard