Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(template): Set versioncontrol from golangci via go.mod #243

Merged
merged 10 commits into from
Feb 26, 2023
Merged

fix(template): Set versioncontrol from golangci via go.mod #243

merged 10 commits into from
Feb 26, 2023

Conversation

linuxluigi
Copy link
Collaborator

Set versioncontrol from golangci via go.mod

@linuxluigi linuxluigi mentioned this pull request Feb 10, 2023
Closed
@linuxluigi
Copy link
Collaborator Author

I'm not sure if this is a great idea...
https://golangci-lint.run/usage/install/#install-from-source

Screenshot 2023-02-13 at 15 55 40

@brumhard
Copy link
Contributor

Well to be honest I didn't have any issues with it in the past half year. So i would consider it fairly stable. If some version breaks you can still pin it for a while.

@linuxluigi
Copy link
Collaborator Author

I run in an issue instantly after migrating it 😂
But for me is the workflow still okay.

@linuxluigi linuxluigi mentioned this pull request Feb 23, 2023
Merged
1 task
brumhard
brumhard previously approved these changes Feb 24, 2023
View reviewed changes
Copy link
Contributor

@brumhard brumhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think we might want to migrate the other tools to this workflow as well (especially the grpc ones) but we can do it in another PR.

@linuxluigi
Copy link
Collaborator Author

Yeah good idea, I try to create a PR soon for that 🙂

@linuxluigi linuxluigi enabled auto-merge (squash) February 25, 2023 09:03
brumhard and others added 8 commits February 25, 2023 10:06
@brumhard @linuxluigi
feat: update codeowners to use github handles (#195)
32a3ba5
@renovate @linuxluigi
chore(deps): update gcr.io/distroless/static:nonroot docker digest to…
49b1dc3 
… 48e033b (#245)

Signed-off-by: Renovate Bot <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate @linuxluigi
chore(deps): update golang:1.19 docker digest to 572f680 (#246)
4e1891d 
Signed-off-by: Renovate Bot <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate @linuxluigi
chore(deps): update golang:1.19 docker digest to 7ce31d1 (#250)
8d58851 
Signed-off-by: Renovate Bot <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate @linuxluigi
chore(deps): update gcr.io/distroless/static:nonroot docker digest to…
90678ea 
… 21e5d22 (#249)

Signed-off-by: Renovate Bot <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@linuxluigi
Trigger CI on PR only (#248)
1feb3b7
@linuxluigi
docs: Use github handles in Readme for codeowners (#247)
df707e2
@linuxluigi
Update semgrep docker image (#251)
2ff87c8 
Signed-off-by: Steffen Exler <[email protected]>
Co-authored-by: Steffen Exler <[email protected]>
@linuxluigi linuxluigi merged commit 8a45b99 into main Feb 26, 2023
@linuxluigi linuxluigi deleted the feature/golangci-version-control-in-go.mod branch April 14, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brumhard brumhard brumhard approved these changes

@danielzwink danielzwink Awaiting requested review from danielzwink

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@linuxluigi @brumhard