Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize return types #24

Open
agerlach opened this issue Aug 17, 2020 · 3 comments
Open

Standardize return types #24

agerlach opened this issue Aug 17, 2020 · 3 comments

Comments

@agerlach
Copy link
Contributor

  • expectation(Koopman()) returns a QuadratureSolution
  • expectation(MonteCarlo()) returns a number/vector
  • centralmoment returns a vector
@ChrisRackauckas
Copy link
Member

They should all be a QuadratureSolution IMO

@agerlach
Copy link
Contributor Author

Agreed. It would be good to try to set resid for all methods too. I know this expensive for MC, so maybe a kwarg flag to turn it on.

@ChrisRackauckas
Copy link
Member

ChrisRackauckas commented Aug 18, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants