V0.20.x merge into main #2079
Merged
V0.20.x merge into main #2079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to a change [1] after beta1, this image has altered somewhat. [1] matplotlib/matplotlib#19619
The test tolerance is too high, and random other changes have crept in so that some show numbers that are completely different from the reference image. * 726ebac changed the `Mercator` projection in `test_set_xyticks` to use the default globe, which changed the text of the ticks from degree-ish to metres. * Ticks are quite clearly requested at 30° increments in `test_set_yticks_cylindrical`, so they definitely should not be at ±31/75°. * Also, fix some small inconsistencies in the tests.
added missing shapefile group to download script
Due to a change [1] after beta1, this image has altered somewhat. [1] matplotlib/matplotlib#19619
instead of hard-coding PlateCarree.
FIX: pcolor shading with nearest
Backport PRs for 0.20.1
Address Shapely 2.0 Deprecations
This adds a cache mechanism to creating Transformer objects, which can be slow when called frequently. Additionally, this requires adding attributes to the Mercator creation as the x/y limits are created in the initializer which uses the cache/hash function.
…-v0.20 Cache transformer crs for v0.20.x
This was missed in the pcolormesh refactor causing some incorrect bounds calculations when plotting the data.
Natural Earth version 5 updated some features, which caused this test to fail the tolerance. Update the image with the new features and remove the old forced edgecolor.
There is some conda-forge issue with Shapely/geos so switch over to Linux for the min dependency tests.
This branch has a different set of updates, causing some of the test tolerances to be changed. Two of these natural earth tests are different because the shapefiles have recently been updated and some features are different now. (For instance, the lakes in the shapefile are now different)
The negotiation with a tile provider needed more up-to-date TLS/SSL protocols, so for now we just pin to a lower openssl on the runners.
Partial cherry-pick of 579be04 to increase the test tolerance of the images for MPL3.5 tests.
Backport recent master commits to v0.20.x
Remove use of setuptools_scm_git_archive
Change to assert_allclose instead of assert_almost_equal to test small changes as recommended by Numpy's testing docs. This is due to small tolerance changes with PROJ 9.0.1.
These only minimally changed with a shifting of the dashes in the gridlines, but no substantive changes.
Depending on the values input to Nightshade, the floating point precision could put the range for arccos outside of [-1, 1], which in turn numpy returns as nan's, yielding bad geometries further downstream. This patch clips the arccos calculations to [-1, 1] to guarantee we aren't out of the valid floating point bounds.
Apparently the images change between PROJ 9.0.0 and 9.0.1
Backports for 0.20.x
dopplershift
approved these changes
Sep 12, 2022
|
I'm surprised there's any change to merge in, but since there's one that looks useful, I'll merge. |
|
There were plenty of merge conflicts, so it may have been me trying to clean one up that was useful, but wasn't actually truly there... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge v0.20.x into main. Not sure if this is the best way to do it by creating a separate branch, so let me know if I should do it a different way, or if we even need to do this.