MNT: remove FeatureArtist.draw args and kwargs #2333
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
I was going to propose deprecating these so I added some deprecation warnings. However, when I tried to trigger those warnings I found that you just can't pass extra parameters here. The method has Matplotlib's
allow_rasterization
decorator which has not passed args and kwargs since matplotlib/matplotlib#20331. Since Matplotlib v3.5 is now our minimum supported version, there is no way these can be used any more. So I propose to just remove them. I had hoped this would lead to simpler code but, unless I'm missing a trick, it doesn't make much difference.Implications
This removes our internal use of the style module so we could consider deprecating that if we wanted.