Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: deprecate the style module #2337

Merged
merged 1 commit into from
Mar 9, 2024
Merged

Conversation

rcomer
Copy link
Member

@rcomer rcomer commented Mar 4, 2024

Rationale

#2323 and #2333 removed our internal use of this module.

This module does 2 things

  • Merges dictionaries of styles taking account of a hard-coded subset of Matplotlib aliases (specifically not plural aliases like facecolors). If this was intended for general use I think it should handle all aliases, maybe making use of ArtistInspector.get_aliases so it could be artist specific. However a utility function for that probably belongs in Matplotlib (if anywhere) rather than here.
  • Handles the Cartopy-specific facecolor="never", but there is some discussion of removing that completely at Make FeatureArtist a Collection #2323 (comment).

Implications

One less module to maintain.

Copy link
Contributor

@greglucas greglucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This module seems like it should have been a private helper and hopefully won't be used by others downstream... Although it does look like it came in fairly recently:
#1190

With your recent changes making FeatureArtist a Collection #2323 I think it is OK to get rid of this now, but it would be good to hear if @pelson or @QuLogic had any other things in mind for this module.

@QuLogic
Copy link
Member

QuLogic commented Mar 9, 2024

If we can avoid having to write our own stuff, that's probably for the best. I don't have any particular plans in mind for this module.

@greglucas greglucas merged commit 46aec1e into SciTools:main Mar 9, 2024
23 checks passed
@rcomer rcomer deleted the deprecate-style branch March 9, 2024 17:20
@rcomer rcomer added this to the Next Release milestone Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants