Reinstate missing renderer argument in GeoAxes._preprocess_draw
#2465
Conversation
jfrost-mo
changed the title
jfrost-mo
changed the title
GeoAxes._preprocess_draw
jfrost-mo
force-pushed
the
missing_renderer_argument
branch
2 times, most recently
from
667fcc2
to
6a62af9
Compare
Commit 454567a changes the method signature of GeoAxes._preprocess_draw. This causes TypeErrors in user code that expects draw to take a renderer argument, notably iris code with bbox_inches="tight". This commit reinstates the argument in the _draw_preprocess function to make the method signature compatible. The value of the argument is never used in the function.
jfrost-mo
force-pushed
the
missing_renderer_argument
branch
from
6a62af9
to
2a988ff
Compare
|
Thanks for your willingness to contribute @jfrost-mo! What Iris version did you test this with? My understanding of the problem is that it happens when However, since the problem is already fixed in the Iris release candidate, I’m not sure it makes sense to also fix it here. |
|
This is failing on Iris 3.10.0, specifically https://conda.anaconda.org/conda-forge/noarch/iris-3.10.0-pyha770c72_1.conda#b7212cd8247ce909631fdcb77015914a Full set of packages: https://github.com/MetOffice/CSET/blob/adad8cc2341607e9fcfe796271368732201b75fc/requirements/locks/py312-lock-linux-64.txt |
|
Right, so when you tested this Cartopy branch, was that definitely with Iris 3.10? I think there was some sort of glitch that meant conda-forge users were getting Iris 3.11rc without deliberately selecting it. |
|
I was using the given conda lockfiles, including hashes, so unless you somehow managed to get around that it should have been 3.10.0. |
|
This has been resolved in iris 3.11.0rc0. |
Rationale
Fixes #2464.
I've reimplemented what I believe was the intent of 454567a from PR #2424, in such a way that it no longer changes the method signature in a problematic way.
Implications
This should now be fully compatible with existing code.
I have manually tested this change however I haven't added any automatic tests. If one is needed then I'm happy to create one.