Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reinstate missing renderer argument in GeoAxes._preprocess_draw #2465

Closed
wants to merge 2 commits into from
Closed

Reinstate missing renderer argument in GeoAxes._preprocess_draw #2465

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9af9ba5
Add dummy renderer argument to _draw_preprocess
jfrost-mo Oct 29, 2024
2a988ff
Add James Frost to list of contributors
jfrost-mo Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/source/contributors.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ the package wouldn't be as rich or diverse as it is today:
* Stephane Raynaud
* John Krasting
* Matthias Cuntz
* James Frost

Thank you!

Expand Down
4 changes: 3 additions & 1 deletion lib/cartopy/mpl/geoaxes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,10 +451,12 @@ def hold_limits(self, hold=True):
self.get_autoscaley_on())
yield

def _draw_preprocess(self):
def _draw_preprocess(self, renderer=None):
"""
Perform pre-processing steps shared between :func:`GeoAxes.draw`
and :func:`GeoAxes.get_tightbbox`.

Renderer argument does nothing, but is retained for API compatibility.
"""
# If data has been added (i.e. autoscale hasn't been turned off)
# then we should autoscale the view.
Expand Down