Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include license and shortcuts in autoupdate in schema.json #2456

Closed
wants to merge 2 commits into from
Closed

Include license and shortcuts in autoupdate in schema.json #2456

wants to merge 2 commits into from

Conversation

se35710
Copy link
Contributor

@se35710 se35710 commented Aug 3, 2018

Fixes #2454

@r15ch13
Copy link
Member

r15ch13 commented Aug 5, 2018

Nice!
But this will not work for shortcuts at the moment.
It requires adding update_manifest_prop "shortcuts" $json $substitutions to autoupdate() and fixing an issues with substitute().
Running substitute() over an multi-array will flatten it out.

"shortcuts": [
    [
        "godot-$version.exe",
        "Godot"
    ]
]

will become

"shortcuts": [
    "godot-3.0.6.exe",
    "Godot"
]

instead of

"shortcuts": [
    [
        "godot-3.0.6.exe",
        "Godot"
    ]
]

Fixing this will also allow us to run update_manifest_prop() on the bin property!
This could reduce the amount of rename post_install scripts.

@se35710
Copy link
Contributor Author

se35710 commented Aug 5, 2018

@r15ch13 I can have a look at it. Should I continue to push into this branch and PR or create a new one?

@rashil2000
Copy link
Member

Merged in #4528

@rashil2000 rashil2000 closed this Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

license property in autoupdate missing in schema.json
4 participants